Skip to content

Conditions shouldn't allocate #11337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pcwalton opened this issue Jan 6, 2014 · 3 comments
Closed

Conditions shouldn't allocate #11337

pcwalton opened this issue Jan 6, 2014 · 3 comments
Labels
I-slow Issue: Problems and improvements with respect to performance of generated code.

Comments

@pcwalton
Copy link
Contributor

pcwalton commented Jan 6, 2014

This is hurting I/O performance quite a bit.

Alternately, just remove conditions.
@lilac
Copy link
Contributor

lilac commented Jan 6, 2014

Do you mean "handler: @handler<T, U>" in the Trap struct?

@pongad
Copy link
Contributor

pongad commented Mar 12, 2014

Close issue since condition is removed?

@alexcrichton
Copy link
Member

Indeed! Conditions were removed in 454882d

flip1995 pushed a commit to flip1995/rust that referenced this issue Sep 7, 2023
@bors
Auto merge of rust-lang#11338 - y21:issue11337, r=Centri3
19eaafb 
allow trait alias DefIds in `implements_trait_with_env_from_iter`

Fixes rust-lang#11337

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-slow Issue: Problems and improvements with respect to performance of generated code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexcrichton @pcwalton @lilac @pongad