Skip to content

new buildsystem has wrongish deps, specifically for libnative #11843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
emberian opened this issue Jan 27, 2014 · 3 comments · Fixed by #11847
Closed

new buildsystem has wrongish deps, specifically for libnative #11843

emberian opened this issue Jan 27, 2014 · 3 comments · Fixed by #11847

Comments

@emberian
Copy link
Member 

$ make check-stage1-std NO_REBUILD=1 NO_BENCH=1

compile_and_link: x86_64-unknown-linux-gnu/stage1/test/stdtest-x86_64-unknown-linux-gnu
/home/cmr/hacking/rust3/src/libstd/lib.rs:67:14: 67:43 error: can't find crate for `native`
/home/cmr/hacking/rust3/src/libstd/lib.rs:67 #[cfg(test)] extern mod native = "native";
                                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/cmr/hacking/rust3/mk/tests.mk:364: recipe for target 'x86_64-unknown-linux-gnu/stage1/test/stdtest-x86_64-unknown-linux-gnu' failed
make: *** [x86_64-unknown-linux-gnu/stage1/test/stdtest-x86_64-unknown-linux-gnu] Error 101

cc @alexcrichton
@emberian
Copy link
Member Author

not sure if actually wrong deps or if the "don't infer version" is biting us.

@emberian
Copy link
Member Author

Confirmed broken after letting a make run through, so it's probably the rustpkg thing?

@pnkfelix
Copy link
Member

cc me

@alexcrichton alexcrichton mentioned this issue Jan 27, 2014
Merged
bors added a commit that referenced this issue Jan 28, 2014
@bors
auto merge of #11847 : alexcrichton/rust/fix-test-deps, r=pcwalton
daf60f0 
The stdtest binary uses both libnative and libgreen to test the two
implementations

Closes #11843
flip1995 pushed a commit to flip1995/rust that referenced this issue Dec 28, 2023
@bors
Auto merge of rust-lang#12004 - PartiallyTyped:11843, r=xFrednet
9dd2252 
New lints `iter_filter_is_some` and `iter_filter_is_ok`

Adds a pair of lints that check for cases of an iterator over `Result` and `Option` followed by `filter` without being followed by `map` as that is covered already by a different, specialized lint.

Fixes rust-lang#11843

PS, I also made some minor documentations fixes in a case where a double tick (`) was included.

---

changelog: New Lint: [`iter_filter_is_some`]
[rust-lang#12004](rust-lang#12004)
changelog: New Lint: [`iter_filter_is_ok`]
[rust-lang#12004](rust-lang#12004)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Depend on libnative when testing alexcrichton/rust
2 participants
@pnkfelix @emberian