Skip to content

bootstrap update notifications: only show what's new #122344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RalfJung opened this issue Mar 11, 2024 · 0 comments · Fixed by #122372
Closed

bootstrap update notifications: only show what's new #122344

RalfJung opened this issue Mar 11, 2024 · 0 comments · Fixed by #122372
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@RalfJung
Copy link
Member

Bootstrap now remembers which "update warnings" it already showed me, and so when I run it the second time it doesn't keep repeating the same messages. That's great. :)

However, when something does change, it prints more than I would expect:

There have been changes to x.py since you last updated:
  [WARNING] The "codegen"/"llvm" profile has been removed and replaced with "compiler", use it instead for the same behavior.
    - PR Link https://github.com/rust-lang/rust/pull/121278
  [INFO] `x install` now skips providing tarball sources (under 'build/dist' path) to speed up the installation process.
    - PR Link https://github.com/rust-lang/rust/pull/118724
  [INFO] A new `boostrap-cache-path` option has been introduced which can be utilized to modify the cache path for bootstrap.
    - PR Link https://github.com/rust-lang/rust/pull/121976
  [INFO] a new `target.*.runner` option is available to specify a wrapper executable required to run tests for a target
    - PR Link https://github.com/rust-lang/rust/pull/122108
  [INFO] New option `rust.llvm-bitcode-linker` that will build the llvm-bitcode-linker.
    - PR Link https://github.com/rust-lang/rust/pull/117458
NOTE: to silence this warning, update `config.toml` to use `change-id = 117458` instead

At least the first 2 I have already seen, but somehow it keeps repeating them every time a new item is added to the list.

Is it possible that when computing which thing to show, it uses the value in the config.toml rather than the value in the "last things I showed" file? If so, would it be possible to only show what's new since the last time something was shown? That way I don't have to re-read the same update notifications over and over again, and the list does not keep growing indefinitely. :)

Cc @onur-ozkan

@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Mar 11, 2024
@onur-ozkan onur-ozkan added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Mar 11, 2024
@workingjubilee workingjubilee added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Mar 11, 2024
@bors bors closed this as completed in 491acfa Mar 16, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Mar 16, 2024
Rollup merge of rust-lang#122372 - onur-ozkan:change-id-improvement, r=Mark-Simulacrum

prevent notifying the same changes more than once

Prevents re-reporting of previously notified changes by using the .last-warned-change-id value for change detection.

Resolves rust-lang#122344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants