Skip to content

./x check is broken for rustdoc #142018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jieyouxu opened this issue Jun 4, 2025 · 0 comments · Fixed by #142002
Closed

./x check is broken for rustdoc #142018

jieyouxu opened this issue Jun 4, 2025 · 0 comments · Fixed by #142002
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Jun 4, 2025

Latest master, default bootstrap.toml (or absent), with or without download-rustc.

$ ./x clean
$ ./x check # broken
$ ./x check rustdoc # broken
@jieyouxu jieyouxu added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. labels Jun 4, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jun 4, 2025
@jieyouxu jieyouxu mentioned this issue Jun 4, 2025
Merged
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jun 4, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jun 4, 2025
@matthiaskrgr
Rollup merge of rust-lang#142002 - onur-ozkan:follow-ups2, r=jieyouxu
dce8dd4 
redesign stage 0 std follow-ups part2

Fixes three bugs:

1. `x check` fails when run on rustdoc without `download-rustc` enabled. (1st commit)
2. `x check` fails when run on the compiler with `download-rustc` enabled. (2nd commit)
3. `x test library` fails with `download-rustc` enabled. (3rd commit)

Fixes rust-lang#142018 (case 1)
Fixes rust-lang#141983 (case 3)
@bors bors closed this as completed in df8102f Jun 4, 2025
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Jun 5, 2025
@bors
Auto merge of #142002 - onur-ozkan:follow-ups2, r=jieyouxu
71ea2ff 
redesign stage 0 std follow-ups part2

Fixes three bugs:

1. `x check` fails when run on rustdoc without `download-rustc` enabled. (1st commit)
2. `x check` fails when run on the compiler with `download-rustc` enabled. (2nd commit)
3. `x test library` fails with `download-rustc` enabled. (3rd commit)

Fixes rust-lang/rust#142018 (case 1)
Fixes rust-lang/rust#141983 (case 3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

redesign stage 0 std follow-ups part2 onur-ozkan/rust
2 participants
@jieyouxu @rustbot