Skip to content

StrAllocating.to_utf16 should be an Iterator<u16> #14358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
huonw opened this issue May 22, 2014 · 1 comment
Closed

StrAllocating.to_utf16 should be an Iterator<u16> #14358

huonw opened this issue May 22, 2014 · 1 comment
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@huonw
Copy link
Member

huonw commented May 22, 2014

http://doc.rust-lang.org/master/std/str/trait.StrAllocating.html#method.to_utf16

This would also allow it to move into core::str.
@schmee
Copy link
Contributor

schmee commented May 30, 2014

I'll submit a PR for this in a day or so.

@huonw huonw mentioned this issue Jun 2, 2014
Closed
@schmee schmee mentioned this issue Jun 2, 2014
Closed
bors added a commit that referenced this issue Jun 17, 2014
@bors
auto merge of #14613 : schmee/rust/utf16-iterator, r=huonw
efdc846 
Closes #14358.

The tests are not yet moved to `utf16_iter`, so this probably won't compile. I'm submitting this PR anyway so it can be reviewed and since it was mentioned in #14611.

This deprecates `.to_utf16`. `x.to_utf16()` should be replaced by either `x.utf16_iter().collect::<Vec<u16>>()` (the type annotation may be optional), or just `x.utf16_iter()` directly, if it can be used in an iterator context.

[breaking-change]

cc @huonw
bors added a commit that referenced this issue Jun 30, 2014
@bors
auto merge of #14613 : schmee/rust/utf16-iterator, r=huonw
a345c54 
Closes #14358.

~~The tests are not yet moved to `utf16_iter`, so this probably won't compile. I'm submitting this PR anyway so it can be reviewed and since it was mentioned in #14611.~~ EDIT: Tests now use `utf16_iter`.

This deprecates `.to_utf16`. `x.to_utf16()` should be replaced by either `x.utf16_iter().collect::<Vec<u16>>()` (the type annotation may be optional), or just `x.utf16_iter()` directly, if it can be used in an iterator context.

[breaking-change]

cc @huonw
@bors bors closed this as completed in 3d84b4b Jun 30, 2014
bors added a commit to rust-lang-ci/rust that referenced this issue Mar 20, 2023
@bors
Auto merge of rust-lang#14358 - Veykril:err-reporting, r=Veykril
1787c14 
Report sysroot and rustc crate loading errors

Also aggregates the warnings and errors so we don't discard previous ones.
cc rust-lang/rust-analyzer#14327
flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 3, 2025
@samueltardieu
suggest is_some_and instead of map_or in `case_sensitive_file_ext…
9d78426 
…ension_comparions` (rust-lang#14358)

close rust-lang#14357

changelog: [`case_sensitive_file_extension_comparisons`]: suggest
`is_some_and` to suppress other lint warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add utf16_units schmee/rust
2 participants
@huonw @schmee