-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Offline docs have absolute URLs in them #14747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Can you clarify which docs you're looking at? These all work for me locally when looking at the libstd docs. |
So, it seems that it's partially a distribution problem. Edited the issue description to reflect this. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this issue
Jun 9, 2014
When generating documentation, rustdoc has the ability to generate relative links within the current distribution of crates to one another. To do this, it must recognize when a crate's documentation is in the same output directory. The current threshold for "local documentation for crate X being available" is whether the directory "doc/X" exists. This change modifies the build system to have new dependencies for each directory of upstream crates for a rustdoc invocation. This will ensure that when building documentation that all the crates in the standard distribution are guaranteed to have relative links to one another. This change is prompted by guaranteeing that offline docs always work with one another. Before this change, races could mean that some docs were built before others, and hence may have http links when relative links would suffice. Closes rust-lang#14747
bors
added a commit
that referenced
this issue
Jun 11, 2014
When generating documentation, rustdoc has the ability to generate relative links within the current distribution of crates to one another. To do this, it must recognize when a crate's documentation is in the same output directory. The current threshold for "local documentation for crate X being available" is whether the directory "doc/X" exists. This change modifies the build system to have new dependencies for each directory of upstream crates for a rustdoc invocation. This will ensure that when building documentation that all the crates in the standard distribution are guaranteed to have relative links to one another. This change is prompted by guaranteeing that offline docs always work with one another. Before this change, races could mean that some docs were built before others, and hence may have http links when relative links would suffice. Closes #14747
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jun 5, 2023
More APIs for `la_arena::IdxRange` ```rust impl<T> ExactSizeIterator for IdxRange<T>; impl<T> Arena<T> { pub fn alloc_many<II: IntoIterator<Item = T>>(&mut self, iter: II) -> IdxRange<T>; } ``` 1. There are no currently ways to get `IdxRange` without manually offseting `Idx`. Providing a method for multiple-allocation simplifies this process and makes it less error-prone. 2. `IdxRange: ExactSizeIterator` makes `iter.zip(range).rev()` possible. Since `Zip: DoubleEndedIterator` requires all its arguments to be `ExactSizeIterator`. It also ease the usage for, eg. `len()`. 3. Fixed a typo. I noticed that `IdxRange::end` may be invalid. Is it good to return `Idx` instead of `RawIdx`?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What doesn't work in the offline docs:
It seems to use fonts it can't reach.Moved to Offline docs use webfonts #14778.What seems to have been a distribution error:
Viewing specifc lines of source.Using the search.The text was updated successfully, but these errors were encountered: