Skip to content

Allow reflection of Box<[T]> #15049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nrc opened this issue Jun 20, 2014 · 1 comment
Closed

Allow reflection of Box<[T]> #15049

nrc opened this issue Jun 20, 2014 · 1 comment

Comments

@nrc
Copy link
Member

nrc commented Jun 20, 2014

Box<[T]> falls out from DST so should work, and mostly it does. Unfortunately, the code for reflecting it got torn out before DST landed and I don't want to delay landing DST any longer for an unpopular feature on an unpopular type. This should be easy to fix.

OTOH, reflection of unsized values doesn't work due to an implementation choice in reflection, so making Smaht<[T]> will be harder to fix, as would doing Box<[T]> properly.

All this probably applies equally to Box<str> too.

@nrc
Copy link
Member Author

nrc commented Oct 16, 2014

We're removing reflection (#18064), so this no longer applies.

@nrc nrc closed this as completed Oct 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant