Remove reflection #18064
Closed
Remove reflection #18064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
luqmana
force-pushed
the
remove-reflection
branch
from
c974b2d to
9db6e3f
Compare
|
Awesome work, thanks @luqmana! |
luqmana
force-pushed
the
remove-reflection
branch
from
9db6e3f to
23e8765
Compare
luqmana
force-pushed
the
remove-reflection
branch
from
23e8765 to
069ea25
Compare
luqmana
force-pushed
the
remove-reflection
branch
3 times, most recently
from
5b8ff8d to
6f35eba
Compare
luqmana
force-pushed
the
remove-reflection
branch
from
6f35eba to
df48516
Compare
| @@ -130,7 +130,7 @@ pub fn decode_inlined_item<'tcx>(cdata: &cstore::crate_metadata, | |||
| None => Err(path), | |||
| Some(ast_doc) => { | |||
| let mut path_as_str = None; | |||
| debug!("> Decoding inlined fn: {}::?", | |||
| debug!("> Decoding inlined fn: {}:", | |||
luqmana
force-pushed
the
remove-reflection
branch
from
20c5768 to
1d028f0
Compare
|
r=me with the nits addressed |
luqmana
force-pushed
the
remove-reflection
branch
2 times, most recently
from
8d60765 to
ca44246
Compare
luqmana
force-pushed
the
remove-reflection
branch
from
ca44246 to
7899248
Compare
bors
added a commit
that referenced
this pull request
Oct 16, 2014
Out goes reflection! This means your code will break if you used the `:?` format specifier, anything else from libdebug, or the `visit_tydesc` intrinsic directly. Closes #18046. [breaking-change]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out goes reflection! This means your code will break if you used the
:?format specifier, anything else from libdebug, or thevisit_tydescintrinsic directly.Closes #18046.
[breaking-change]