Should IntoStr trait be renamed to IntoString?

[jasonthompson]

re #15493 and #15046

-IntoStr/into_str was renamed to IntoStr/into_string. Should the trait be renamed to IntoString?

-Also, shouldn't the file libstd/to_str.rs be renamed to libstd/to_string.rs.

I'm happy to do fix the first point--I did a quick search through src and IntoStr is only used in a few other files. But I'm not sure what kind of issues renaming the file would create.

[aturon]

Yes, IntoStr and into_str should be renamed to IntoString and into_string.

Instead of renaming the to_str.rs file and module, I would rather move the module into collections::string. I would also like to move std::from_str into the core::str module. (Some of the impls in the module would have to move elsewhere.)

@alexcrichton Do you see any reason not to do the above?

[alexcrichton]

Sounds good to me! Moving from_str into core may be difficult because of some of the impls for primitives like floats, but other than that it shouldn't be so bad.

[jasonthompson]

I'll take a whack at moving the module into collections::string.

[steveklabnik]

These traits are all gone now.