Skip to content

std::f32::consts shouldn't be blank #18156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mdinger opened this issue Oct 19, 2014 · 3 comments · Fixed by #19793
Closed

std::f32::consts shouldn't be blank #18156

mdinger opened this issue Oct 19, 2014 · 3 comments · Fixed by #19793
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@mdinger
Copy link
Contributor

mdinger commented Oct 19, 2014

std::f32::consts and std::f64::consts are blank and probably shouldn't be. i8-64 and u8-64 don't have consts sections.

This is probably temporary and related to constants being shuffled but I couldn't find the issue regarding it.
@sfackler
Copy link
Member

I think they're showing up blank because rustdoc doesn't render consts.

@sfackler sfackler added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 19, 2014
@mdinger
Copy link
Contributor Author

mdinger commented Oct 19, 2014

I expected to find constants like pi and e there but I'm not sure which ones should actually be there.

@sfackler
Copy link
Member

They're all there, but they're consts so rustdoc isn't outputting them: http://doc.rust-lang.org/src/core/home/rustbuild/src/rust-buildbot/slave/nightly-linux/build/src/libcore/num/f32.rs.html#48-105

@mdinger mdinger mentioned this issue Dec 11, 2014
Closed
@tomjakubowski tomjakubowski mentioned this issue Dec 12, 2014
Merged
tomjakubowski added a commit to tomjakubowski/rust that referenced this issue Dec 12, 2014
@tomjakubowski
rustdoc: Properly inline const items
25223c8 
Build `clean::ConstantItem` values in the `inline` module and
pretty-print the AST for inlined const items.

Doc strings are still missing from inlined constants (see rust-lang#19773).

Partially address rust-lang#18156, rust-lang#19722, rust-lang#19185

Fix rust-lang#15821
brson added a commit to brson/rust that referenced this issue Dec 12, 2014
@brson
rollup merge of rust-lang#19774: tomjakubowski/rustdoc-consts-statics
eb2ce7f 
Build `clean::ConstantItem` values in the `inline` module and
pretty-print the AST for inlined const items.

Doc strings are still missing from inlined constants (see rust-lang#19773).

Partially address rust-lang#18156, rust-lang#19722, rust-lang#19185

Fix rust-lang#15821

r? @alexcrichton
brson added a commit to brson/rust that referenced this issue Dec 13, 2014
@brson
rollup merge of rust-lang#19774: tomjakubowski/rustdoc-consts-statics
5b4ba62 
Build `clean::ConstantItem` values in the `inline` module and
pretty-print the AST for inlined const items.

Doc strings are still missing from inlined constants (see rust-lang#19773).

Partially address rust-lang#18156, rust-lang#19722, rust-lang#19185

Fix rust-lang#15821

r? @alexcrichton
tomjakubowski added a commit to tomjakubowski/rust that referenced this issue Dec 13, 2014
@tomjakubowski
metadata: Encode attributes for const items
31f75ac 
Fix rust-lang#19773

Together with rust-lang#19774 (which this is rebased on):

Fix rust-lang#18156, fix rust-lang#19722, fix rust-lang#19185
@tomjakubowski tomjakubowski mentioned this issue Dec 13, 2014
Merged
brson added a commit to brson/rust that referenced this issue Dec 15, 2014
@brson
rollup merge of rust-lang#19774: tomjakubowski/rustdoc-consts-statics
3673486 
Build `clean::ConstantItem` values in the `inline` module and
pretty-print the AST for inlined const items.

Doc strings are still missing from inlined constants (see rust-lang#19773).

Partially address rust-lang#18156, rust-lang#19722, rust-lang#19185

Fix rust-lang#15821

r? @alexcrichton
brson added a commit to brson/rust that referenced this issue Dec 15, 2014
@brson
rollup merge of rust-lang#19793: tomjakubowski/metadata-const-attrs
77d2a11 
Fix rust-lang#19773

Together with rust-lang#19774 (which this is rebased on):

Fix rust-lang#18156, fix rust-lang#19722, fix rust-lang#19185

r? @alexcrichton (since this was your suggestion!)
lnicola pushed a commit to lnicola/rust that referenced this issue Sep 25, 2024
@bors
Auto merge of rust-lang#18162 - ChayimFriedman2:gat-object-safe, r=Ve…
5bc2e65 
…ykril

fix: Consider lifetime GATs object unsafe

Fixes rust-lang#18156.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

metadata: Encode attributes for const items tomjakubowski/rust
2 participants
@sfackler @mdinger