-
Notifications
You must be signed in to change notification settings - Fork 13.3k
doc: Book uses Result::expect() but still makes reference to Option::expect() #31912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This has been fixed in nightly: https://doc.rust-lang.org/nightly/book/guessing-game.html
|
The first line looks fixed, but the second doesn't, "we can use these two little methods" is still present. |
I thought I accepted PRs for all of it, will double check. Thanks. |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this issue
Mar 9, 2016
When it was Option.expect(), there was an .ok().expect(), but now that it uses Result.expect(), there's only one method, not two. Fixes rust-lang#31912
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this issue
Mar 10, 2016
Small grammar fix in Guessing Game When it was Option.expect(), there was an .ok().expect(), but now that it uses Result.expect(), there's only one method, not two. Fixes rust-lang#31912
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this issue
Mar 10, 2016
Small grammar fix in Guessing Game When it was Option.expect(), there was an .ok().expect(), but now that it uses Result.expect(), there's only one method, not two. Fixes rust-lang#31912
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://doc.rust-lang.org/book/guessing-game.html contains statements like
The book used to use
.ok().expect(...)
, but has switched to.expect(...)
, from two methods for error handling/crashing to one.The text was updated successfully, but these errors were encountered: