Skip to content

Move all intrinsic declarations into intrinsic.rs. Document them #3369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brson opened this issue Sep 4, 2012 · 8 comments
Closed

Move all intrinsic declarations into intrinsic.rs. Document them #3369

brson opened this issue Sep 4, 2012 · 8 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Sep 4, 2012

Our declarations for "rust-intrinsic" functions are currently located wherever they are needed. It would be more useful and probably more maintainable to just declare them all in the injected intrinsic.rs file. Also, they should be documented, because they are currently pretty mysterious.

@eholk
Copy link
Contributor

eholk commented Sep 10, 2012

At one point during the summer, I started documenting these here: https://github.com/mozilla/rust/wiki/Note-rust-intrinsics

I obviously didn't get real far...

@brson
Copy link
Contributor Author

brson commented Jan 18, 2013

intrinsic.rs is injected by the compiler, so I don't think that's a great place for these - still not discoverable. I would rather just put them in core::private::intrinsics now.

@graydon
Copy link
Contributor

graydon commented Mar 25, 2013

non-critical for 0.6, de-milestoning

@z0w0
Copy link
Contributor

z0w0 commented Jun 6, 2013

What remains to be done for this? The file exists, so would all intristic definitions still remaining in other files need to be changed to use private::intristics before this can be closed?

@graydon
Copy link
Contributor

graydon commented Jun 12, 2013

std::unstable::intrinsics has all these now, the move is done. they are mostly documented, just missing docs on some math fns.

@catamorphism
Copy link
Contributor

backwards-compatible looks wrong; re-nominating for milestone 1, well-defined.

@catamorphism
Copy link
Contributor

Just a bug, de-nominating

@brson
Copy link
Contributor Author

brson commented Oct 18, 2013

Done.

@brson brson closed this as completed Oct 18, 2013
RalfJung pushed a commit to RalfJung/rust that referenced this issue Mar 15, 2024
simplify no-std tests

set panic=abort so that we do not need this eh_personality thing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

5 participants