Rustc no longer builds for msvc 17 #48749
Labels
Comments
|
@snf can you provide more logs for this build? |
|
https://pastebin.mozilla.org/9079141 was the log posted on IRC. The issue is that when using MSBuild as the cmake generator |
|
Also please never hardcode |
|
Ah thanks @ollie27! Yes I can look into fixing this. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this issue
Mar 9, 2018
For LLD integration the path to `llvm-config` needed to change to inside the build directory itself (for whatever reason) but the build directory is different on MSBuild than it is on `ninja` for MSVC builds, so the path to `llvm-config.exe` was actually wrong and not working! This commit removes the `Build::llvm_config` function in favor of the source of truth, the `Llvm` build step itself. The build step was then updated to find the right build directory for MSBuild as well as `ninja` for where `llvm-config.exe` is located. Closes rust-lang#48749
bors
added a commit
that referenced
this issue
Mar 9, 2018
rustbuild: Fix MSBuild location of `llvm-config.exe` For LLD integration the path to `llvm-config` needed to change to inside the build directory itself (for whatever reason) but the build directory is different on MSBuild than it is on `ninja` for MSVC builds, so the path to `llvm-config.exe` was actually wrong and not working! This commit removes the `Build::llvm_config` function in favor of the source of truth, the `Llvm` build step itself. The build step was then updated to find the right build directory for MSBuild as well as `ninja` for where `llvm-config.exe` is located. Closes #48749
bors
added a commit
that referenced
this issue
Mar 9, 2018
rustbuild: Fix MSBuild location of `llvm-config.exe` For LLD integration the path to `llvm-config` needed to change to inside the build directory itself (for whatever reason) but the build directory is different on MSBuild than it is on `ninja` for MSVC builds, so the path to `llvm-config.exe` was actually wrong and not working! This commit removes the `Build::llvm_config` function in favor of the source of truth, the `Llvm` build step itself. The build step was then updated to find the right build directory for MSBuild as well as `ninja` for where `llvm-config.exe` is located. Closes #48749
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It appears to be since this commit yesterday: d69b248#diff-9a46b13a265be2ded97369dddf5037f5
@alexcrichton can you have a look at it?, discussing in IRC, it seems that changing the line 88 back from "build/bin" to only "bin" does the work.
The text was updated successfully, but these errors were encountered: