-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Incorrect span with bad imports #6074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This would clean up the final detail of #3027. |
Was this closed because it can no longer be reproduced? |
I fixed it in #6347, partially, and have a few more patches to fix up the other cases. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Oct 9, 2020
…, r=matthiaskrgr Fix a FP in `explicit_counter_loop` Fixes rust-lang#4677 and rust-lang#6074 Fix a false positive in `explicit_counter_loop` where the loop counter is used after incremented, adjust the test so that counters are incremented at the end of the loop and add the test for this false positive. --- changelog: Fix a false positive in `explicit_counter_loop` where the loop counter is used after incremented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
generates:
I believe the span on the first error should just cover foo, not the whole path (that is a path, yes?)
The text was updated successfully, but these errors were encountered: