Skip to content

Typo in https://doc.rust-lang.org/rustdoc/documentation-tests.html#attributes #70856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pavelrappo opened this issue Apr 6, 2020 · 1 comment · Fixed by #70914
Closed

Typo in https://doc.rust-lang.org/rustdoc/documentation-tests.html#attributes #70856

pavelrappo opened this issue Apr 6, 2020 · 1 comment · Fixed by #70914
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@pavelrappo
Copy link

pavelrappo commented Apr 6, 2020 •
edited
Loading

edition2018 tells rustdoc that the code sample should be compiled the 2018 edition of Rust.

That doesn't look right. I suppose one of with, on, or using is missing.
@jonas-schievink jonas-schievink added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 6, 2020
@pavelrappo
Copy link
Author

Also,

Using thses options looks like this:

https://doc.rust-lang.org/rustdoc/unstable-features.html#--runtool---runtool-arg-program-to-run-tests-with-args-to-pass-to-it

This was referenced Apr 7, 2020
Closed
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Apr 8, 2020
@Dylan-DPC
Rollup merge of rust-lang#70914 - tsandstr:typo1, r=Dylan-DPC
9a84771 
Corrects a typo in rustdoc documentation.

Fixes rust-lang#70856

Sorry, I am just learning git and I think I may have accidentally done some wacky stuff that closed my last PR. Here it is again.
@bors bors closed this as completed in d55c399 Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
2 participants
@jonas-schievink @pavelrappo