make check
should use a performance ratchet
#7459
Labels
A-testsuite
Area: The testsuite used to check the correctness of rustc
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
I-slow
Issue: Problems and improvements with respect to performance of generated code.
We should have performance tests that are "not allowed to get worse" in the testsuite. The operation should involve reading a .json file with the last run values, comparing to current-run values, failing if any regress, and rewriting the file if any advanced. Buildbot can potentially deposit the .json file before each build if it's missing, and harvest it after for display / plotting, and users can just work with the one(s) in their own workspaces.
This requires either objective performance criteria or fuzzy forms of comparison. Prefer objective when possible.
valgrind --tool=lackey
andperf stat
can gather number of instructions retired, which tends to be much more stable than clock time.Probably easier to base this on metrics gathered from #6810
The text was updated successfully, but these errors were encountered: