Skip to content

llvm-wrapper: adapt for LLVM API change #100627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2022
Merged

Conversation

krasimirgg
Copy link
Contributor

@krasimirgg krasimirgg commented Aug 16, 2022

No functional changes intended.

LLVM commit llvm/llvm-project@633f566 removed createWriteThinLTOBitcodePass.
This adapts PassWrapper similarly to the example mentioned upstream: llvm/llvm-project@853b57f.

Detected via our experimental rust + llvm @ head bot: https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/12768#0182a6be-ed6e-4dc6-a230-7a46f9d3a2c2/205-537

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 16, 2022
@rust-highfive
Copy link
Contributor

r? @cuviper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 16, 2022
@krasimirgg
Copy link
Contributor Author

r? @nikic

@rust-highfive rust-highfive assigned nikic and unassigned cuviper Aug 16, 2022
@krasimirgg krasimirgg marked this pull request as ready for review August 16, 2022 14:43
No functional changes intended.

LLVM commit llvm/llvm-project@633f566 removed `createWriteThinLTOBitcodePass`.
This adapts PassWrapper similarly to the example mentioned upstream: llvm/llvm-project@633f566.
@krasimirgg
Copy link
Contributor Author

r? @cuviper

@rust-highfive rust-highfive assigned cuviper and unassigned nikic Aug 17, 2022
@cuviper
Copy link
Member

cuviper commented Aug 17, 2022

Thanks! Blocking rollups so we can see the perf effect, if any.

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Aug 17, 2022

📌 Commit 7cba1f9 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2022
@bors
Copy link
Collaborator

bors commented Aug 21, 2022

⌛ Testing commit 7cba1f9 with merge 39a9b88...

@bors
Copy link
Collaborator

bors commented Aug 21, 2022

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 39a9b88 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 21, 2022
@bors bors merged commit 39a9b88 into rust-lang:master Aug 21, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 21, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (39a9b88): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.3% 3.3% 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.9% -2.9% 1
All ❌✅ (primary) - - 0

Cycles

Results
  • Primary benchmarks: ✅ relevant improvement found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.4% -3.4% 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.4% -3.4% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2

  2. number of relevant changes 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants