Fix the temporary name of the object file created #10260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file did not respect the #[link(name = "...")] attribute when it was clearly intended to do so. The problem is that the crate attributes just weren't passed in. This causes lots of problems in rust today because the object file for all our libraries is inferred to be 'lib.o' because all of the files are called 'lib.rs'. I tried to figure out a good way to test for this, but I wasn't able to come up with a good way that fit into our current testing framework. Nonetheless, I have tested this locally and object files get named as they should. This should fix compiling with `make -jN` again (because the object files are all different again).
bors
added a commit
that referenced
this pull request
Nov 4, 2013
This file did not respect the #[link(name = "...")] attribute when it was clearly intended to do so. The problem is that the crate attributes just weren't passed in. This causes lots of problems in rust today because the object file for all our libraries is inferred to be 'lib.o' because all of the files are called 'lib.rs'. I tried to figure out a good way to test for this, but I wasn't able to come up with a good way that fit into our current testing framework. Nonetheless, I have tested this locally and object files get named as they should. This should fix compiling with `make -jN` again (because the object files are all different again).
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 10, 2023
`multiple_unsafe_ops_per_block`: Don't lint in external macros Fixes rust-lang#10259 changelog: FP: [`multiple_unsafe_ops_per_block`]: No longer lints in external macros [rust-lang#10260](rust-lang/rust-clippy#10260) <!-- changelog_none -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file did not respect the #[link(name = "...")] attribute when it was
clearly intended to do so. The problem is that the crate attributes just weren't
passed in. This causes lots of problems in rust today because the object file
for all our libraries is inferred to be 'lib.o' because all of the files are
called 'lib.rs'.
I tried to figure out a good way to test for this, but I wasn't able to come up
with a good way that fit into our current testing framework. Nonetheless, I have
tested this locally and object files get named as they should. This should fix
compiling with
make -jNagain (because the object files are all differentagain).