Use LLVM's integrated assembler on Windows #10874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is pretty awesome! If there's only one failing use case, I'm not sure there's any reason to keep around the code for the external assembler at all though. In your programs, have you run into any other problems other than that one test case? |
|
I figured that it might be useful in the future to debug something, or if integrated assembler gets broken on some platform again. Besides, clang has this option too. |
|
If nothing else, it's useful to work around a bug in the LLVM assembler (of which there are plenty). |
bors
added a commit
that referenced
this pull request
Dec 9, 2013
Last LLVM update seems to have fixed whatever prevented LLVM integrated assembler from generating correct unwind tables on Windows. This PR switches Windows builds to use internal assembler by default. Compilation via external assembler can still be requested via the newly added `-Z no-integrated-as` option. Closes #8809
|
cc #10872 |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2023
…,xFrednet [`ptr_cast_constness`]: Only lint on casts which don't change type fixes rust-lang#10874 changelog: [`ptr_cast_constness`]: Only lint on casts which don't change type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last LLVM update seems to have fixed whatever prevented LLVM integrated assembler from generating correct unwind tables on Windows. This PR switches Windows builds to use internal assembler by default.
Compilation via external assembler can still be requested via the newly added
-Z no-integrated-asoption.Closes #8809