-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Suggest defining const parameter when appropriate #110041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (56e0626): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
Helps a bit with #91119.
Following #105523's lead, I use placeholder
/* Type */
instead of_
in the suggestion.It should be easier for newcomers to parse.
@rustbot label A-diagnostics
r? diagnostics