Skip to content

Change the wording in std::fmt::Write::write_str #112959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2023
Merged

Change the wording in std::fmt::Write::write_str #112959

merged 2 commits into from
Sep 28, 2023

Conversation

tbu-
Copy link
Contributor

@tbu- tbu- commented Jun 23, 2023

Refer to the error instead of expanding its name.

@rustbot
Copy link
Collaborator

rustbot commented Jun 23, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 23, 2023
@m-ou-se
Copy link
Member

m-ou-se commented Jun 26, 2023

The full path std::fmt::Error seems useful to show, to distinguish it from std::io::Error (which is used by the very similar std::io::Write trait).

@tbu- tbu- force-pushed the pr_fmt_error_wording branch from d357404 to 7f469f8 Compare June 27, 2023 15:21
@tbu-
Copy link
Contributor Author

tbu- commented Jun 27, 2023

The full path std::fmt::Error seems useful to show, to distinguish it from std::io::Error (which is used by the very similar std::io::Write trait).

Added the path to the line above.

@tbu-
Change the wording in std::fmt::Write::write_str
659c17a 
Refer to the error instead of expanding its name.
@tbu- tbu- force-pushed the pr_fmt_error_wording branch from 7f469f8 to 659c17a Compare June 27, 2023 15:22
@rust-log-analyzer

This comment has been minimized.

Sign in to view
dtolnay
dtolnay requested changes Sep 28, 2023
View reviewed changes
@dtolnay dtolnay assigned dtolnay and unassigned m-ou-se Sep 28, 2023
@dtolnay
Fix "unresolved link to std::fmt::Error"
e2f7032 
error: unresolved link to `std::fmt::Error`
       --> library/core/src/fmt/mod.rs:115:52
        |
    115 |     /// This function will return an instance of [`std::fmt::Error`] on error.
        |
        |
        = note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings`
dtolnay
dtolnay approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Sep 28, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 28, 2023

📌 Commit e2f7032 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 28, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 28, 2023
@bors
Auto merge of rust-lang#116222 - matthiaskrgr:rollup-dnag90q, r=matth…
6e09cff 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#112959 (Change the wording in `std::fmt::Write::write_str`)
 - rust-lang#115535 (format doc-comment code examples in std::process)
 - rust-lang#115888 (fix a comment about assert_receiver_is_total_eq)
 - rust-lang#116211 (more clippy complextity fixes )
 - rust-lang#116213 (Document -Zlink-native-libraries)
 - rust-lang#116215 (Tweak wording of missing angle backets in qualified path)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 980fba7 into rust-lang:master Sep 28, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 28, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 28, 2023
@rust-timer
Unrolled build for rust-lang#112959
b630245 
Rollup merge of rust-lang#112959 - tbu-:pr_fmt_error_wording, r=dtolnay

Change the wording in `std::fmt::Write::write_str`

Refer to the error instead of expanding its name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
6 participants
@tbu- @rustbot @m-ou-se @rust-log-analyzer @dtolnay @bors