std::rt: require known stack bounds for all tasks. #11360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me, nice work! I'd like to run this by @brson before r+'ing, however |
We just approximate with a 1 or 2 MB stack for native::start.
| #[cfg(android)] | ||
| static OS_DEFAULT_STACK_ESTIMATE: uint = 1 << 20; | ||
| #[cfg(unix, not(android))] | ||
| static OS_DEFAULT_STACK_ESTIMATE: uint = 2 * (1 << 20); |
There was a problem hiding this comment.
@brson fixed; some googling indicates that Android has a 1 MB stack by default too.
bors
added a commit
that referenced
this pull request
Jan 10, 2014
We just approximate with a 2MB stack for native::start.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 7, 2023
[`iter_overeager_cloned`]: detect .cloned().all() and .cloned().any() changelog: [`iter_overeager_cloned`] r? `@blyxyas`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just approximate with a 2MB stack for native::start.