-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Update windows ffi bindings #114882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update windows ffi bindings #114882
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
I've rebased this PR on the newly released version of |
This comment has been minimized.
This comment has been minimized.
This allows `SOCKET` to be `usize` internally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (dd91aba): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 630.425s -> 631.736s (0.21%) |
Bump
windows-bindgen
to version 0.51.1. This brings with it some changes to the generated FFI bindings, but little that affects the code.One change that does have more of an impact is
SOCKET
beingusize
instead of eitheru64
oru32
(as is used in std's publicSOCKET
type). However, it's now easy enough to abstract over that difference.Finally I added a few new bindings that are likely to be used in pending PRs, mostly to make sure they're ok with the new metadata.
r? libs