Skip to content

improve container runner script #119165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 24, 2023

Conversation

onur-ozkan
Copy link
Member

@onur-ozkan onur-ozkan commented Dec 20, 2023

First commit fixes #118930

Second commit is mostly for development purposes. In read-only mode submodules cannot be initialized due to access limitations (see the log below), which means that tools cannot be built.

Updating submodule src/tools/cargo
error: could not lock config file .git/config: Read-only file system
error: could not lock config file .git/config: Read-only file system
fatal: Failed to register url for submodule path 'src/tools/cargo'
error: could not lock config file .git/config: Read-only file system
error: could not lock config file .git/config: Read-only file system
fatal: Failed to register url for submodule path 'src/tools/cargo'
Build completed unsuccessfully in 0:00:00

@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2023

r? @Kobzol

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 20, 2023
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some concerns regarding the second commit (left a note).

The first commit looks ok, although I wasn't able to reproduce the original problem locally.

@onur-ozkan onur-ozkan force-pushed the update-container-entrypoint branch from fd4b4ea to b498489 Compare December 23, 2023 21:59
@onur-ozkan onur-ozkan requested a review from Kobzol December 23, 2023 21:59
@Kobzol
Copy link
Contributor

Kobzol commented Dec 23, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 23, 2023

📌 Commit b498489 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 24, 2023
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#119165 (improve container runner script)
 - rust-lang#119205 (fix minor mistake in comments describing VecDeque resizing)
 - rust-lang#119257 (interpret/memory: explain why we check is_thread_local_static)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 09131a2 into rust-lang:master Dec 24, 2023
@rustbot rustbot added this to the 1.77.0 milestone Dec 24, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 24, 2023
Rollup merge of rust-lang#119165 - onur-ozkan:update-container-entrypoint, r=Kobzol

improve container runner script

First commit fixes rust-lang#118930

Second commit is mostly for development purposes. In read-only mode submodules cannot be initialized due to access limitations (see the log below), which means that tools cannot be built.

```sh
Updating submodule src/tools/cargo
error: could not lock config file .git/config: Read-only file system
error: could not lock config file .git/config: Read-only file system
fatal: Failed to register url for submodule path 'src/tools/cargo'
error: could not lock config file .git/config: Read-only file system
error: could not lock config file .git/config: Read-only file system
fatal: Failed to register url for submodule path 'src/tools/cargo'
Build completed unsuccessfully in 0:00:00

```
@onur-ozkan onur-ozkan deleted the update-container-entrypoint branch February 17, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
4 participants