-
Notifications
You must be signed in to change notification settings - Fork 13.3k
improve container runner script #119165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bors
merged 2 commits into
rust-lang:master
from
onur-ozkan:update-container-entrypoint
Dec 24, 2023
Merged
improve container runner script #119165
bors
merged 2 commits into
rust-lang:master
from
onur-ozkan:update-container-entrypoint
Dec 24, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: onur-ozkan <[email protected]>
r? @Kobzol (rustbot has picked a reviewer for you, use r? to override) |
Kobzol
reviewed
Dec 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some concerns regarding the second commit (left a note).
The first commit looks ok, although I wasn't able to reproduce the original problem locally.
Signed-off-by: onur-ozkan <[email protected]>
fd4b4ea
to
b498489
Compare
@bors r+ rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 24, 2023
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#119165 (improve container runner script) - rust-lang#119205 (fix minor mistake in comments describing VecDeque resizing) - rust-lang#119257 (interpret/memory: explain why we check is_thread_local_static) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 24, 2023
Rollup merge of rust-lang#119165 - onur-ozkan:update-container-entrypoint, r=Kobzol improve container runner script First commit fixes rust-lang#118930 Second commit is mostly for development purposes. In read-only mode submodules cannot be initialized due to access limitations (see the log below), which means that tools cannot be built. ```sh Updating submodule src/tools/cargo error: could not lock config file .git/config: Read-only file system error: could not lock config file .git/config: Read-only file system fatal: Failed to register url for submodule path 'src/tools/cargo' error: could not lock config file .git/config: Read-only file system error: could not lock config file .git/config: Read-only file system fatal: Failed to register url for submodule path 'src/tools/cargo' Build completed unsuccessfully in 0:00:00 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit fixes #118930
Second commit is mostly for development purposes. In read-only mode submodules cannot be initialized due to access limitations (see the log below), which means that tools cannot be built.