Feature gate all quasi-quoting macros. #12025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,6 +49,12 @@ static KNOWN_FEATURES: &'static [(&'static str, Status)] = &[ | |||
| ("trace_macros", Active), | |||
| ("simd", Active), | |||
| ("default_type_params", Active), | |||
| ("quote_tokens", Active), | |||
There was a problem hiding this comment.
Maybe these could all be covered by the same gate (e.g. called quote)?
There was a problem hiding this comment.
Yes, I didn't think about it. It seems that there was only one "quote" macro, but later split to multiple ones.
I am not sure if there is a gain to keep them separate in feature gate as well.
If not, I am happy to replace with a single gate, that is simpler.
There was a problem hiding this comment.
Yes to the single, simple quote feature gate.
|
Thanks! |
bors
added a commit
that referenced
this pull request
Feb 5, 2014
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
minor: Document completion context some more
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 11, 2024
Include GitLab in the CI section of the clippy doc book Fixes rust-lang#12012 changelog: Docs: [`Continuous Integration`] now includes how to use clippy in GitLab CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11630.