interpret/memory: fix safety comment for large array memset optimization #120387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
oli-obk
reviewed
Jan 29, 2024
| // that this read at type `u8` is OK -- it must be an initialized byte. | ||
| if size_in_bytes == 1 { | ||
| debug_assert!(num_copies >= 1); // we already handled the zero-sized cases above. | ||
| // SAFETY: `src_bytes` would be read from anyway by `copy` below (num_copies >= 1). | ||
| let value = *src_bytes; | ||
| dest_bytes.write_bytes(value, (size * num_copies).bytes_usize()); |
There was a problem hiding this comment.
This line seems more dangerous and we don't have a comment on it at all 😆 I'll try to add one this week
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix the doc comment for
check_and_deref_ptr.