Skip to content

Portable SIMD subtree update #121269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Feb 19, 2024
Merged

Portable SIMD subtree update #121269

merged 30 commits into from
Feb 19, 2024

Conversation

calebzulawski
Copy link
Member

Syncs nightly to the latest changes from rust-lang/portable-simd

r? @rust-lang/libs

Also, fixes #119904 which is now fixed upstream.

RalfJung and others added 30 commits December 3, 2023 16:02
@RalfJung
fix simd_bitmask docs
81af496
@calebzulawski
Fix bitmask vector bit order
289c1d1
@calebzulawski
Merge pull request rust-lang#378 from RalfJung/simd_bitmask
80ff6a5 
fix simd_bitmask docs
@programmerjake
Fix load/store safety comments to require aligned T
c705775 
Fixes: rust-lang#382
@calebzulawski
Merge pull request rust-lang#383 from programmerjake/programmerjake-p…
1273da6 
…atch-1

Fix load/store safety comments to require aligned `T`
@workingjubilee
Assume masks are correct
b6eeb4e 
This allows miri to detect when they are not, and
may be exploited by LLVM during optimization.
@calebzulawski
Use core::intrinsics
bb50fa2
@calebzulawski
Add exposed_provenance for rust-lang#118487
e7130ec
@calebzulawski
Merge pull request rust-lang#386 from rust-lang/core-intrinsics
97007cc 
Use core::intrinsics
@calebzulawski
Merge pull request rust-lang#380 from rust-lang/bitmask-order
f55ca30 
Fix bitmask vector bit order
@RalfJung
re-add const_intrinsic_copy feature
4e36929
@RalfJung
stdsimd feature got split up
047ba0a
@calebzulawski
Merge pull request rust-lang#389 from RalfJung/const_intrinsic_copy
f505736 
fix feature flags
@RalfJung
use core::intrinsics::simd
851ef63
@calebzulawski
Merge pull request rust-lang#391 from RalfJung/core-intrinsics
b2e1bcb 
use core::intrinsics::simd
@calebzulawski
Merge pull request rust-lang#385 from workingjubilee/make-an-ass-out-…
6ad779c 
…of-u-and-me

Assume masks are correct
@calebzulawski
Minor fixes
a2dd4a3
@calebzulawski
Revert "Merge pull request rust-lang#385 from workingjubilee/make-an-…
644bdfb 
…ass-out-of-u-and-me"

This reverts commit 6ad779c, reversing
changes made to b2e1bcb.
@calebzulawski
Add back core_intrinsics
d8439e9
@calebzulawski
Merge pull request rust-lang#392 from rust-lang/minor-fixes
061d5ac 
Revert rust-lang#385 and add some minor fixes
@calebzulawski
Revert "Revert "Merge pull request rust-lang#385 from workingjubilee/…
44b4d26 
…make-an-ass-out-of-u-and-me""

This reverts commit 644bdfb.
@calebzulawski
Use intrinsics directly to avoid recursion
aebf6f1
@calebzulawski
Merge pull request rust-lang#393 from rust-lang/assume-masks-are-correct
7348d2d 
Assume masks are correct
@calebzulawski
Remove link to core::arch::x86_64
afa70e6
@Urgau @calebzulawski
Fix target_feature config in portable-simd
64bd26f
@Amanieu @calebzulawski
Disable conversions between portable_simd and stdarch on big-endian ARM
9aec60e 
stdarch no longer provide SIMD on big-endian ARM due to
rust-lang/stdarch#1484
@calebzulawski
Merge pull request rust-lang#394 from rust-lang/sync-upstream-2024-02-17
e06e54c 
Sync upstream 2024 Feb 17
@calebzulawski
Fix swizzle_dyn
eee4f1d
@calebzulawski
Merge pull request rust-lang#395 from rust-lang/swizzle_dyn_fix
6491107 
Fix swizzle_dyn
@calebzulawski
Merge commit '649110751ef4f27440d7cc711b3e07d11bf02d4a' into sync-por…
b2691ba 
…table-simd-2024-02-18
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 18, 2024
@rustbot
Copy link
Collaborator

rustbot commented Feb 18, 2024

Portable SIMD is developed in its own repository. If possible, consider making this change to rust-lang/portable-simd instead.

cc @calebzulawski, @programmerjake

@calebzulawski calebzulawski mentioned this pull request Feb 18, 2024
Merged
@calebzulawski
Copy link
Member Author

Never had a subtree update pass first try. Ready to go!

@Mark-Simulacrum
Copy link
Member

Is there a reason you r'd libs on this instead of self-approving? Typically subtree updates aren't actually reviewed on rust-lang/rust; they're unwieldy to do any real review with.

@bors delegate+ r+ rollup=never

@bors
Copy link
Collaborator

bors commented Feb 18, 2024

✌️ @calebzulawski, you can now approve this pull request!

If @Mark-Simulacrum told you to "r=me" after making some further change, please make that change, then do @bors r=@Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Feb 18, 2024

📌 Commit b2691ba has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2024
@calebzulawski
Copy link
Member Author

calebzulawski commented Feb 18, 2024 •
edited
Loading

I don't have commit permissions :) Thanks!

@calebzulawski calebzulawski mentioned this pull request Feb 18, 2024
Merged
@bors
Copy link
Collaborator

bors commented Feb 19, 2024

⌛ Testing commit b2691ba with merge d573564...

@bors
Copy link
Collaborator

bors commented Feb 19, 2024

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing d573564 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 19, 2024
@bors bors merged commit d573564 into rust-lang:master Feb 19, 2024
@rustbot rustbot added this to the 1.78.0 milestone Feb 19, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d573564): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.4% [-0.4%, -0.4%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.4% [-0.4%, -0.4%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -4.0% [-4.0%, -4.0%] 1
Improvements ✅
(secondary)		 -5.0% [-5.0%, -5.0%] 1
All ❌✅ (primary) -4.0% [-4.0%, -4.0%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.6% [2.2%, 3.0%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.1% [0.1%, 0.1%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.1% [0.1%, 0.1%] 1

Bootstrap: 640.336s -> 640.888s (0.09%)
Artifact size: 308.82 MiB -> 308.82 MiB (0.00%)

@kornelski kornelski mentioned this pull request Jul 30, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.

portable-simd's swizzle_dyn miscompiles on x86-64
10 participants
@calebzulawski @rustbot @Mark-Simulacrum @bors @rust-timer @RalfJung @programmerjake @workingjubilee @Urgau @Amanieu