Cleanup windows abort_internal

[ChrisDenton]

As the comments on the functions say, we define abort in both in panic_abort and in libstd. This PR makes the two implementation (mostly) the same.

Additionally it:

• uses options(noreturn) on the asm instead of using core::intrinsics::unreachable.
• removed unnecessary allow lints
• added FAST_FAIL_FATAL_APP_EXIT to our generated Windows API bindings instead of defining it manually (std only)

[rustbot]

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[ChrisDenton]

It seems that miri is very sensitive to std's abort function being exactly what it expects, So I've moved the miri implementation to a separate function and added a note about avoiding disturbing it.

[joboet]

As this touches the inline assembly options anyway, we might as well add a nostack attribute so that LLVM doesn't think that it needs to adjust the stack pointer. But that's really nitpicky, you don't have to bother...

r=me otherwise

[joboet]

@bors r+

[bors]

📌 Commit ce26c78 has been approved by joboet

It is now in the queue for this repository.

[bors]

⌛ Testing commit ce26c78 with merge 3793e5b...

[bors]

☀️ Test successful - checks-actions
Approved by: joboet
Pushing 3793e5b to master...

[rust-timer]

Finished benchmarking commit (3793e5b): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	1
Improvements ✅ (primary)	-2.8%	[-2.8%, -2.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.8%	[-2.8%, -2.8%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.9%	[2.7%, 4.7%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-3.4%, -2.0%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.5%	[-2.5%, -2.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.7%	[-2.5%, 1.1%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 648.592s -> 650.632s (0.31%)
Artifact size: 175.05 MiB -> 175.02 MiB (-0.02%)

[lqd]

Wins and losses are noise

@rustbot label: +perf-regression-triaged