-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add a tidy check that checks whether the fluent slugs only appear once #121860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
☔ The latest upstream changes (presumably #121859) made this pull request unmergeable. Please resolve the merge conflicts. |
8105e5f
to
976a5ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a proper review of it, and I think the algorithm can be simplified. After that, happy to merge! I was surprised to see that the performance of it is still really good, not being slower than before.. I guess compute is just so cheap compared to (my quite fast!) disk :)
Awesome, thanks! |
Is there anything wrong? Why hasn't this PR been merged yet 🤔 |
it's in the queue, weird. |
@bors rollup |
As @Nilstrieb said in #121828 (comment):
We can get the tidy check error:
r? @Nilstrieb