Skip to content

std::thread: set_name change for solaris/illumos. #123323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2024
Merged

std::thread: set_name change for solaris/illumos. #123323

merged 1 commit into from
Apr 2, 2024

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Apr 1, 2024

truncate down to 32 (31 + 1) for solaris/illumos.

@rustbot
Copy link
Collaborator

rustbot commented Apr 1, 2024

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 1, 2024
@workingjubilee
Copy link
Member

@devnexen hm. from whence this particular constant?

@devnexen
Copy link
Contributor Author

devnexen commented Apr 1, 2024

from here.

workingjubilee
workingjubilee approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah!

@workingjubilee
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 1, 2024

📌 Commit 61289a0 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2024
@workingjubilee
Copy link
Member

@bors rollup

@workingjubilee workingjubilee mentioned this pull request Apr 1, 2024
Closed
@workingjubilee
Copy link
Member

@devnexen hey, can you check if this stdlib compiles for illumos?

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 1, 2024
@devnexen
std::thread: set_name change for solaris/illumos.
ca36fe3 
truncate down to 32 (31 + 1) for solaris/illumos.
@devnexen devnexen force-pushed the thread_set_name_solaris_fix branch from 61289a0 to ca36fe3 Compare April 1, 2024 21:16
@workingjubilee
Copy link
Member

Nice, thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 2, 2024

📌 Commit ca36fe3 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 2, 2024
@workingjubilee workingjubilee mentioned this pull request Apr 2, 2024
Merged
@bors bors merged commit 48b2a51 into rust-lang:master Apr 2, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workingjubilee workingjubilee workingjubilee approved these changes

Assignees

@workingjubilee workingjubilee

Labels
O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
4 participants
@devnexen @rustbot @workingjubilee @bors