Rollup of 9 pull requests

[matthiaskrgr]

Successful merges:

• stabilize const_fn_floating_point_arithmetic #128596 (stabilize const_fn_floating_point_arithmetic)
• make writes_through_immutable_pointer a hard error #129199 (make writes_through_immutable_pointer a hard error)
• Retroactively feature gate ConstArgKind::Path #129246 (Retroactively feature gate ConstArgKind::Path)
• Pin cc to 1.0.105 #129290 (Pin cc to 1.0.105)
• Implement ptr::fn_addr_eq #129323 (Implement ptr::fn_addr_eq)
• remove invalid TyCompat relation for effects #129500 (remove invalid TyCompat relation for effects)
• panicking: improve hint for Miri's RUST_BACKTRACE behavior #129501 (panicking: improve hint for Miri's RUST_BACKTRACE behavior)
• interpret: ImmTy: tighten sanity checks in offset logic #129505 (interpret: ImmTy: tighten sanity checks in offset logic)
• Fix elided_named_lifetimes in code #129510 (Fix elided_named_lifetimes in code)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[matthiaskrgr]

@bors r+ rollup=never p=9

[bors]

📌 Commit e664ff5 has been approved by matthiaskrgr

It is now in the queue for this repository.

[bors]

⌛ Testing commit e664ff5 with merge 313db53...

[bors]

⌛ Testing commit e664ff5 with merge 3557abf...

[rust-log-analyzer]

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] miri test:false 4.635
error: failed to remove file `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-tools\x86_64-pc-windows-msvc\release\miri.exe`

Caused by:
  Access is denied. (os error 5)
Command has failed. Rerun with -v to see more details.
  local time: Sun, Aug 25, 2024  5:43:09 AM
  network time: Sun, 25 Aug 2024 05:43:10 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

[bors]

💔 Test failed - checks-actions

[tgross35]

@bors retry, #127883 again

[bors]

⌛ Testing commit e664ff5 with merge 717aec0...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 717aec0 to master...

[tgross35]

Hey Bors did two in a row! 🎉

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#128596	stabilize const_fn_floating_point_arithmetic	e265baf261475158308e10e8b41b60d21ed3480b (link)
#129199	make writes_through_immutable_pointer a hard error	d1643c9612eb9214a6d156a0b51aa560e15f13d3 (link)
#129246	Retroactively feature gate ConstArgKind::Path	e8cb34bffaef3a640a854773b032c84192ca017b (link)
#129290	Pin cc to 1.0.105	44289e3dfa5abf97ada3ea1138b72791f1d130af (link)
#129323	Implement ptr::fn_addr_eq	b194e68fe2ddfdba0ccb799937e024ff120c76b8 (link)
#129500	remove invalid TyCompat relation for effects	51728b59bb68abd83859144a8b988d55e66d1217 (link)
#129501	panicking: improve hint for Miri's RUST_BACKTRACE behavior	0033e166143a523efd581814f356db22b4a57299 (link)
#129505	interpret: ImmTy: tighten sanity checks in offset logic	ea268e1f610c96fb7c7aa297a8e8da8f9bec6450 (link)
#129510	Fix elided_named_lifetimes in code	37eb9c233abe5ba23fe62f670dd4cb7397c49719 (link)

previous master: 697d9530d7

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (717aec0): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.4%, 0.9%]	6
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.7%	[0.4%, 0.9%]	6

Max RSS (memory usage)

Results (primary -0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.3%	[2.1%, 2.4%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.6%	[-2.4%, -1.1%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-2.4%, 2.4%]	5

Cycles

Results (primary -0.3%, secondary 2.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.7%	[1.7%, 1.7%]	1
Regressions ❌ (secondary)	2.5%	[2.5%, 2.5%]	1
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-2.3%, 1.7%]	2

Binary size

Results (primary 0.0%, secondary -0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.0%, 1.1%]	23
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.2%	[-0.6%, -0.1%]	36
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	0.0%	[-0.6%, 1.1%]	59

Bootstrap: 749.664s -> 750.871s (0.16%)
Artifact size: 338.97 MiB -> 338.73 MiB (-0.07%)

[pnkfelix]

Visiting for weekly rustc-perf triage

• primary regressions are solely to various incremental scenarios for the bitmaps crate
• PR Do not call source_span when not tracking dependencies. #129513 and PR Get rid of predicates_defined_on #129546 seem to have recovered much of the losses here... but after review, they are probably just masking the loss introduced by PR Rollup of 9 pull requests #129521
• opened discussion in zulip about how to actually dig more deeply into regressions like this.
• nothing here seems like it should have impacted incr-comp, and this regression seems minor enough that it does not warrant deeper investigation
• marking as triaged

@rustbot label: +perf-regression-triaged