Skip to content

chore: remove repetitive words #129885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2024
Merged

chore: remove repetitive words #129885

merged 1 commit into from
Sep 3, 2024

Conversation

cuishuang
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Sep 2, 2024

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 2, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 2, 2024

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

jieyouxu
jieyouxu requested changes Sep 2, 2024
View reviewed changes
@scottmcm
Copy link
Member

scottmcm commented Sep 2, 2024

I often think PRs like this are more trouble than they're worth, in terms of occupying contributor time when the mistake didn't actually confuse people.

But now that it's here and it's down to just s/the the/the/g, sure, might as well
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 2, 2024

📌 Commit 25c4aa8 has been approved by scottmcm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2024
@saethlin
Copy link
Member

saethlin commented Sep 2, 2024

I often think PRs like this are more trouble than they're worth, in terms of occupying contributor time when the mistake didn't actually confuse people.

In the recent past, some libs reviewers have explicitly volunteered to review such PRs.

@workingjubilee
Copy link
Member

Yes, hello!

It is reasonably important to me that user-facing documentation is free of frivolous typos, even if I basically don't really care about how internal comments look.

@workingjubilee
Copy link
Member

Also note this basically implies that changes outside of ./library should only be submitted if you're really really sure it's an improvement.

@matthiaskrgr matthiaskrgr mentioned this pull request Sep 3, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 3, 2024
@bors
Auto merge of rust-lang#129922 - matthiaskrgr:rollup-4vqx8ct, r=matth…
d6c8169 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#129152 (custom/external clippy support for bootstrapping)
 - rust-lang#129311 (don't copy `.rustc-dev-contents` from CI rustc)
 - rust-lang#129800 (Move the Windows remove_dir_all impl into a module and make it more race resistant)
 - rust-lang#129860 (update `object` dependency to remove duplicate `wasmparser`)
 - rust-lang#129885 (chore: remove repetitive words)
 - rust-lang#129913 (Add missing read_buf stub for x86_64-unknown-l4re-uclibc)
 - rust-lang#129916 (process.rs: remove "Basic usage" text where not useful)
 - rust-lang#129917 (Fix parsing of beta version in dry-run mode)

r? `@ghost`
`@rustbot` modify labels: rollup
@cuishuang
Copy link
Contributor Author

Also note this basically implies that changes outside of ./library should only be submitted if you're really really sure it's an improvement.

Okay, thanks

@bors bors merged commit afb9232 into rust-lang:master Sep 3, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 3, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 3, 2024
@rust-timer
Unrolled build for rust-lang#129885
1fccea1 
Rollup merge of rust-lang#129885 - cuishuang:master, r=scottmcm

chore: remove repetitive words
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

@saethlin saethlin saethlin left review comments

@tgross35 tgross35 tgross35 left review comments

@jieyouxu jieyouxu jieyouxu requested changes

Assignees

@scottmcm scottmcm

Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
9 participants
@cuishuang @rustbot @scottmcm @bors @saethlin @workingjubilee @RalfJung @tgross35 @jieyouxu