-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add copy button to crate version. #130374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Looks good overall. Could you add a screenshot please? |
There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged. You can start a rebase with the following commands:
The following commits are merge commits: |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Guillaume Gomez <[email protected]>
The job Click to see the possible cause of the failure (guessed by this bot)
|
What do you think about this change @notriddle ? |
Doesn't docs.rs already have a button to do it in its menu bar? Also, the button should be on the baseline, just like it is in the main header. But the redundancy is the biggest problem. What could we do to make what we already have easier to understand, instead of adding to it? |
☔ The latest upstream changes (presumably #136564) made this pull request unmergeable. Please resolve the merge conflicts. |
Triage: comment is not answered and need rebase |
This PR closes #111143.
Instead of copying strictly the crate version number, this implementation copies a Cargo.toml 'snippet' (the same behavior as the Crates.io copy button). i.e. For a crate called
very_useful_crate
on version0.1.0
, the copied string would be:very_useful_crate = "0.1.0"
.