Skip to content

GCC backend subtree update #130948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 66 commits into from
Sep 28, 2024
Merged

GCC backend subtree update #130948

merged 66 commits into from
Sep 28, 2024

Conversation

GuillaumeGomez
Copy link
Member

We just finished the last sync so time to sync back.

cc @antoyo

sapir and others added 30 commits August 5, 2024 00:37
@sapir
Update Cargo.lock
f7f9a3f
@sapir
Implement CodeModel
f579dee
@sapir
Replace stack_var_count and RETURN_VALUE_COUNT with a single counter
014a840
@antoyo
Merge pull request rust-lang#548 from sapir/code-model
0475182 
Code model
@antoyo
Merge pull request rust-lang#549 from sapir/value-counter
fb95096 
Replace stack_var_count and RETURN_VALUE_COUNT with a single counter
@sapir
Remove dummy value locals for function ptr calls
4fe1647
@antoyo
Merge pull request rust-lang#554 from sapir/remove-void-func-debug-var
2cc32ba 
Remove dummy value locals for function ptr calls
@compiler-errors @GuillaumeGomez
Give Instance::expect_resolve a span
3eb2844
@compiler-errors @GuillaumeGomez
Fix spans
007fa3b
@RalfJung @GuillaumeGomez
Miri function identity hack: account for possible inlining
fb47385
@compiler-errors @GuillaumeGomez
Remove lang feature for type ascription
24ab684
@bjorn3 @GuillaumeGomez
Sync ar_archive_writer to LLVM 18.1.3
6199de2 
From LLVM 15.0.0-rc3. This adds support for COFF archives containing
Arm64EC object files and has various fixes for AIX big archive files.
@GuillaumeGomez
Align cg_gcc rustfmt.toml with rust's
f34f3c7
@GuillaumeGomez
Format cg_gcc with same formatting parameters
fd56f44
@slanterns @GuillaumeGomez
stabilize is_sorted
88f7508
@nnethercote @GuillaumeGomez
Reformat use declarations.
1cbbac3 
The previous commit updated `rustfmt.toml` appropriately. This commit is
the outcome of running `x fmt --all` with the new formatting options.
@nicholasbishop @GuillaumeGomez
Update compiler_builtins to 0.1.114
78f5ee6 
The `weak-intrinsics` feature was removed from compiler_builtins in
rust-lang/compiler-builtins#598, so dropped the
`compiler-builtins-weak-intrinsics` feature from alloc/std/sysroot.

In rust-lang/compiler-builtins#593, some
builtins for f16/f128 were added. These don't work for all compiler
backends, so add a `compiler-builtins-no-f16-f128` feature and disable
it for cranelift and gcc. Also disable it for LLVM targets that don't
support it.
@bjorn3 @GuillaumeGomez
Move temp file name generation out of the create_dll_import_lib method
c57eb55
@bjorn3 @GuillaumeGomez
Move computation of decorated names out of the create_dll_import_lib …
50b3746 
…method
@calebzulawski @GuillaumeGomez
Refactor and fill out target feature lists
e80199c
@calebzulawski @GuillaumeGomez
Hide implicit target features from diagnostics when possible
51130e1
@GuillaumeGomez
Update compiler-builtins version to 0.1.118
f824fb6
@Nadrieril @GuillaumeGomez
Fixes in various places
b373147
@GuillaumeGomez
Update compiler version to nightly-2024-08-11
8bd9b48
@GuillaumeGomez
Fix libcore patch
dd76ad4
@GuillaumeGomez
Fix patch libgccjit12/0001-core-Disable-portable-simd-test.patch
8643c13
@GuillaumeGomez
Rename compiler-builtins-no-f16-f128 into `std/compiler-builtins-no…
fb6118b 
…-f16-f128`
@GuillaumeGomez
Update sysroot Cargo.lock
3b45cf4
@GuillaumeGomez @antoyo
Unpin compiler-builtins
afb14f7 
Co-authored-by: Antoni Boucher <[email protected]>
@antoyo
Add missing impl Copy for *mut T
b70a1ec
@rustbot
Copy link
Collaborator

rustbot commented Sep 27, 2024

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 27, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 27, 2024

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Sep 27, 2024
@GuillaumeGomez
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 27, 2024

📌 Commit d0102fd has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2024
@GuillaumeGomez
Copy link
Member Author

Almost forgot:

@bors rollup=never

@GuillaumeGomez
Copy link
Member Author

And also a little priority because it's very conflict prone...

@bors p=1

@saethlin
Copy link
Member

I don't trust that nobody will push a rollup ahead of this.
@bors p=21

@bors
Copy link
Collaborator

bors commented Sep 28, 2024

⌛ Testing commit d0102fd with merge b6576e3...

@bors
Copy link
Collaborator

bors commented Sep 28, 2024

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing b6576e3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 28, 2024
@bors bors merged commit b6576e3 into rust-lang:master Sep 28, 2024
8 of 13 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 28, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b6576e3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.2% [1.2%, 1.2%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.3% [-3.3%, -3.3%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.1% [-3.3%, 1.2%] 2

Cycles

Results (secondary 3.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.5% [3.3%, 3.6%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 774.905s -> 774.209s (-0.09%)
Artifact size: 341.40 MiB -> 341.42 MiB (0.00%)

@GuillaumeGomez GuillaumeGomez deleted the subtree-update branch September 28, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chenyukang chenyukang

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.