[DO NOT MERGE] bootstrap with -Znext-solver=globally

[lcnr]

A revival of #124812.

Current status:

./x.py b --stage 2 passes 🎉

try builds succeed 🎉 🎉 🎉

top 100 most downloaded crates on crates.io compile

top 1000 most downloaded crates on crates.io compile

first perf run 👻

in-flight changes

• alias-relate: add fast reject optimization #124852, unsure whether I actually want to land this PR for now
• support revealing uses of opaques in closures #139587
• https://github.com/lcnr/rust/tree/opaque-type-method-call
• Properly stall coroutine witnesses in new solver #138845
• Don't assemble non-env/bound candidates if projection is rigid #139762
• double the available recursion depth in the new solver ☠️

r? @ghost

[compiler-errors]

@bors try

[bors]

⌛ Trying commit f631ca8 with merge ca04381...

[compiler-errors]

I also pushed:

• Deeply normalize when computing implied outlives bounds #133517
• Structurally resolve before checking ! in HIR typeck #133518
• Check xform_ret_ty for WF in the new solver to improve method winnowing #133519
• Structurally resolve before applying projection in borrowck #133520
• Structurally resolve before matching on type of projection #133521
• Cache in DeepRejectCtxt #133524

I think this is sufficient to make the compiler build, or at least ./x.py build --stage=2 completes successfully on my local branch.

[bors]

💔 Test failed - checks-actions

[bors]

☔ The latest upstream changes (presumably #133527) made this pull request unmergeable. Please resolve the merge conflicts.

[lqd]

Next failure is on color-print-proc-macro-0.3.6 while building cargo.

pub fn repro() -> impl FnMut() {
    if true {
        || ()
    } else {
        || ()
    }
}

godbolt

[compiler-errors]

@bors try

[bors]

⌛ Trying commit 6210ed3 with merge ac5ccad...

[bors]

💔 Test failed - checks-actions

[compiler-errors]

@bors try

[bors]

⌛ Trying commit 8fa8f40 with merge 550ae0d...

[lqd]

I was reducing the new failure but you've already fixed it ^^

[compiler-errors]

@bors try

[bors]

⌛ Trying commit 6318a50 with merge 406365b...

[bors]

💔 Test failed - checks-actions

[compiler-errors]

@bors try

[bors]

⌛ Trying commit 2d8656f with merge 306c6ad...

[rust-log-analyzer]

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

info: removing rustup binaries
info: rustup is uninstalled
##[group]Image checksum input
mingw-check-tidy
# We use the ghcr base image because ghcr doesn't have a rate limit
# and the mingw-check-tidy job doesn't cache docker images in CI.
FROM ghcr.io/rust-lang/ubuntu:22.04

ARG DEBIAN_FRONTEND=noninteractive
RUN apt-get update && apt-get install -y --no-install-recommends \
  g++ \
  make \
---

COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/

# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
           --stage 0 src/tools/tidy tidyselftest --extra-checks=py,cpp
#
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
#    pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---
#12 2.870 Building wheels for collected packages: reuse
#12 2.871   Building wheel for reuse (pyproject.toml): started
#12 3.087   Building wheel for reuse (pyproject.toml): finished with status 'done'
#12 3.088   Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132719 sha256=5bb60f62728aaedff7162745ce743c7f2f55069b3e7f82e6a37d70df455797cc
#12 3.088   Stored in directory: /tmp/pip-ephem-wheel-cache-gvuwqloh/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#12 3.091 Successfully built reuse
#12 3.091 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#12 3.498 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#12 3.498 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#12 4.064 Collecting virtualenv
#12 4.101   Downloading virtualenv-20.30.0-py3-none-any.whl (4.3 MB)
#12 4.182      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 4.3/4.3 MB 55.2 MB/s eta 0:00:00
#12 4.237 Collecting platformdirs<5,>=3.9.1
#12 4.240   Downloading platformdirs-4.3.7-py3-none-any.whl (18 kB)
#12 4.276 Collecting filelock<4,>=3.12.2
#12 4.280   Downloading filelock-3.18.0-py3-none-any.whl (16 kB)
#12 4.297 Collecting distlib<1,>=0.3.7
#12 4.300   Downloading distlib-0.3.9-py2.py3-none-any.whl (468 kB)
#12 4.309      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 469.0/469.0 KB 77.9 MB/s eta 0:00:00
#12 4.390 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#12 4.575 Successfully installed distlib-0.3.9 filelock-3.18.0 platformdirs-4.3.7 virtualenv-20.30.0
#12 4.575 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#12 DONE 4.7s

#13 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#13 DONE 0.0s
---
DirectMap4k:      122816 kB
DirectMap2M:     8265728 kB
DirectMap1G:    10485760 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test            --stage 0 src/tools/tidy tidyselftest --extra-checks=py,cpp
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py,cpp
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
[TIMING] core::build_steps::tool::LibcxxVersionTool { target: x86_64-unknown-linux-gnu } -- 0.212
---
fmt check
fmt: checked 5981 files
tidy check
tidy: Skipping binary file check, read-only filesystem
##[error]tidy error: /checkout/compiler/rustc_ty_utils/src/opaque_types.rs:359: TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME
##[error]tidy error: /checkout/compiler/rustc_borrowck/src/region_infer/opaque_types.rs:38: TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME
##[error]tidy error: /checkout/compiler/rustc_borrowck/src/region_infer/opaque_types.rs:300: TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME
##[error]tidy error: /checkout/compiler/rustc_borrowck/src/region_infer/opaque_types.rs:430: TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME
##[error]tidy error: /checkout/compiler/rustc_trait_selection/src/solve/fulfill.rs:250: TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME
##[error]tidy error: /checkout/compiler/rustc_trait_selection/src/solve/normalize.rs:63: TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME
##[error]tidy error: /checkout/compiler/rustc_next_trait_solver/src/solve/trait_goals.rs:277: TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME
removing old virtual environment
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10' and 'venv'
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10' and 'virtualenv'
Requirement already satisfied: pip in ./build/venv/lib/python3.10/site-packages (25.0.1)
linting python files
All checks passed!
checking python file formatting
26 files already formatted
checking C++ file formatting
some tidy checks failed
Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:01:41
  local time: Fri Apr 18 23:26:16 UTC 2025
  network time: Fri, 18 Apr 2025 23:26:17 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

[bors]

☀️ Try build successful - checks-actions
Build commit: 306c6ad (306c6aded24f02440063be828ebe601fe5eb8323)

[compiler-errors]

@craterbot check crates=top-10000

[craterbot]

👌 Experiment pr-133502-3 created and queued.
🤖 Automatically detected try build 306c6ad
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-133502-3 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🎉 Experiment pr-133502-3 is completed!
📊 437 regressed and 0 fixed (10000 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more