Reduce the amount of explicit FatalError.raise() #134561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
rustbot
added
S-waiting-on-review
Instead use dcx.abort_if_error() or guar.raise_fatal() instead. These guarantee that an error actually happened previously and thus we don't silently abort.
bjorn3
force-pushed
the
less_fatal_error_raise
branch
from
03ef0e8 to
701e2f7
Compare
compiler-errors
approved these changes
Dec 20, 2024
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Dec 20, 2024
…ompiler-errors Reduce the amount of explicit FatalError.raise() Instead use dcx.abort_if_error() or guar.raise_fatal() instead. These guarantee that an error actually happened previously and thus we don't silently abort.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 20, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#134556 ([tiny] fix missing ns units in bootstrap's benchmark rendering) - rust-lang#134560 (mri: add track_caller to thread spawning methods for better backtraces) - rust-lang#134561 (Reduce the amount of explicit FatalError.raise()) - rust-lang#134562 (tests/codegen/asm: Remove uses of rustc_attrs and lang_items features by using minicore) - rust-lang#134567 (Remove some dead code around import library generation) - rust-lang#134570 (remove reference to dangling from slice::Iter) - rust-lang#134573 (unimplement `PointerLike` for trait objects) - rust-lang#134574 (next-solver: disable unnecessary hack) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 20, 2024
Rollup merge of rust-lang#134561 - bjorn3:less_fatal_error_raise, r=compiler-errors Reduce the amount of explicit FatalError.raise() Instead use dcx.abort_if_error() or guar.raise_fatal() instead. These guarantee that an error actually happened previously and thus we don't silently abort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead use dcx.abort_if_error() or guar.raise_fatal() instead. These guarantee that an error actually happened previously and thus we don't silently abort.