-
Notifications
You must be signed in to change notification settings - Fork 13.3k
bootstrap: flip compile::Rustc
vs compile::Assemble
#135023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The PathSet prefix matching unfortunately also has implications for `./x build compiler`, because the path filter `"compiler"` gets consumed by `compile::Rustc` step first after PathSet prefix matching, whereas before PathSet prefix matching, the later-registered `compile::Assemble` step would've consumed the `"compiler"` path filter. This merely papers over the issue with PathSet prefix handling to unblock contributors for using `./x build compiler`.
rustbot has assigned @Mark-Simulacrum. Use |
r? @onur-ozkan (you likely have more context) |
Tested manually by deleting a load-bearing method in |
feel free to r=me |
This wouldn't be observable in CI anyway, so |
@bors p=1 (contributor roadblock, but feel free to include this in a rollup if someone is making one) |
compile::Rustc
vs compile::Assemble
compile::Rustc
vs compile::Assemble
☀️ Test successful - checks-actions |
Finished benchmarking commit (6ca6659): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -1.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 2.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 763.526s -> 763.315s (-0.03%) |
The
PathSet
prefix matching unfortunately also has implications for./x build compiler --stage 0
, because the path filter"compiler"
gets consumed bycompile::Rustc
step first afterPathSet
prefix matching, whereas beforePathSet
prefix matching,compile::Rustc
would not have consumed"compiler"
.This merely papers over #134970 to unblock contributors from using
./x build compiler --stage 0
.The
PathSet
prefix matching behavior is tracked in #135022.Closes #134970.