Skip to content

move footnote to ordinary comment #135150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2025
Merged

move footnote to ordinary comment #135150

merged 1 commit into from
Jan 6, 2025

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Jan 6, 2025

cc #135057

@rustbot
Copy link
Collaborator

rustbot commented Jan 6, 2025

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 6, 2025
@oli-obk
Copy link
Contributor

oli-obk commented Jan 6, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 6, 2025

📌 Commit ae6a331 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 6, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 6, 2025
@bors
Auto merge of rust-lang#135151 - matthiaskrgr:rollup-2vy1hwl, r=matth…
13738b0 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#135111 (Add doc aliases for `libm` and IEEE names)
 - rust-lang#135129 (triagebot: label `src/doc/rustc-dev-guide` changes with `A-rustc-dev-guide`)
 - rust-lang#135132 (dev guide ping group and set adhoc reviewers to compiler)
 - rust-lang#135145 (Mention `unnameable_types` in `unreachable_pub` documentation.)
 - rust-lang#135147 (A few borrowck tweaks to improve 2024 edition migration lints)
 - rust-lang#135150 (move footnote to ordinary comment)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c5c05c2 into rust-lang:master Jan 6, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 6, 2025
@rust-timer
Unrolled build for rust-lang#135150
6850cb8 
Rollup merge of rust-lang#135150 - lcnr:unconstrained-lts-comment, r=oli-obk

move footnote to ordinary comment

cc rust-lang#135057
@rustbot rustbot added this to the 1.86.0 milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lcnr @rustbot @oli-obk @bors