Rename rustc_middle::Ty::is_unsafe_ptr to is_raw_ptr

[1c3t3a]

The wording unsafe pointer is less common and not mentioned in a lot of places, instead this is usually called a "raw pointer". For the sake of uniformity, we rename this method.
This came up during the review of
#134424.

r? @Noratrieb

[rustbot]

Could not assign reviewer from: Noratrieb.
User(s) Noratrieb are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

[rustbot]

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

Some changes occurred to the CTFE machinery

cc @rust-lang/wg-const-eval

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

[Noratrieb]

r? Noratrieb

testing something

[rustbot]

Noratrieb has insufficient capacity to be assigned the pull request at this time. PR assignment has been reverted.

Please choose another assignee.

(see documentation)

[Noratrieb]

r? oli-obk

more testing

[rustbot]

Could not assign reviewer from: oli-obk.
User(s) oli-obk are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

[RalfJung]

coerce_unsafe_ptr should also be renamed.

Clippy also has a lint with unsafe_ptr in the name -- but that would better be changed in a clippy PR (if you want, otherwise filing an issue to record this mismatch is also fine).

[rustbot]

Noratrieb has insufficient capacity to be assigned the pull request at this time. PR assignment has been reverted.

Please choose another assignee.

(see documentation)

[rustbot]

You have insufficient capacity to be assigned the pull request at this time. PR assignment has been reverted.

Please choose another assignee or increase your assignment limit.

(see documentation)

[Noratrieb]

r? oli-obk

[Centri3]

Clippy also has a lint with unsafe_ptr in the name -- but that would better be changed in a clippy PR (if you want, otherwise filing an issue to record this mismatch is also fine).

I believe you are speaking on not_unsafe_ptr_arg_deref? The unsafe is mentioning a fn not being marked unsafe - not the raw pointer. I don't believe this is necessary (but I concur it is still a weird lint name!)

[rustbot]

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

This PR changes Stable MIR

cc @oli-obk, @celinval, @ouz-a

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

[rustbot]

The Miri subtree was changed

cc @rust-lang/miri

[RalfJung]

I believe you are speaking on not_unsafe_ptr_arg_deref? The unsafe is mentioning a fn not being marked unsafe - not the raw pointer. I don't believe this is necessary (but I concur it is still a weird lint name!)

Ah I see, makes sense.

[workingjubilee]

apparent merge conflicts?

@bors r-

[workingjubilee]

even with the master branch I mean.

also
@bors rollup=iffy

[1c3t3a]

apparent merge conflicts?

@bors r-

Yes! Just rebased after #134424 has landed :)

[1c3t3a]

This should work now :) Sorry for the confusion, the other patch landed first and broke this one.

[bors]

☔ The latest upstream changes (presumably #136751) made this pull request unmergeable. Please resolve the merge conflicts.

[1c3t3a]

Friendly ping on this change :) Should be ready to merge once again!

[1c3t3a]

@workingjubilee @oli-obk Is there anything that blocks this from landing? I saw that Jubilee was r-'ing this patch but I assume that is because of the merge conflict that's now resolved, or do I miss something? :)

[oli-obk]

@bors r+

[bors]

📌 Commit 0c7d5e2 has been approved by oli-obk

It is now in the queue for this repository.

[bors]

⌛ Testing commit 0c7d5e2 with merge 6dce9f8...

[bors]

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 6dce9f8 to master...

[rust-timer]

Finished benchmarking commit (6dce9f8): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 2.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.4%	[2.1%, 2.8%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 790.496s -> 788.472s (-0.26%)
Artifact size: 347.84 MiB -> 347.85 MiB (0.00%)