Skip to content

bump stdarch #137932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

bump stdarch #137932

wants to merge 2 commits into from

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Mar 3, 2025

@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2025

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 3, 2025
@RalfJung
Copy link
Member Author

RalfJung commented Mar 3, 2025

Seems like it has been a while since the last update... let's hope this goes smooth.

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling tracing-log v0.2.0
error: unnecessary `unsafe` block
  --> compiler/rustc_span/src/analyze_source_file.rs:86:38
   |
86 |                 let multibyte_test = unsafe { _mm_cmplt_epi8(chunk, _mm_set1_epi8(0)) };
   |
   = note: `-D unused-unsafe` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unused_unsafe)]`


error: unnecessary `unsafe` block
  --> compiler/rustc_span/src/analyze_source_file.rs:88:38
   |
88 |                 let multibyte_mask = unsafe { _mm_movemask_epi8(multibyte_test) };

error: unnecessary `unsafe` block
  --> compiler/rustc_span/src/analyze_source_file.rs:95:41
   |
   |
95 |                     let newlines_test = unsafe { _mm_cmpeq_epi8(chunk, _mm_set1_epi8(b'\n' as i8)) };

error: unnecessary `unsafe` block
  --> compiler/rustc_span/src/analyze_source_file.rs:96:45
   |
   |
96 |                     let mut newlines_mask = unsafe { _mm_movemask_epi8(newlines_test) };

   Compiling rustc_baked_icu_data v0.0.0 (/checkout/compiler/rustc_baked_icu_data)
error: could not compile `rustc_span` (lib) due to 4 previous errors
warning: build failed, waiting for other jobs to finish...

@Noratrieb
Copy link
Member

rust-lang/stdarch#1714 looks like you need to remove the unsafe blocks.

@Noratrieb Noratrieb added the relnotes Marks issues that should be documented in the release notes of the next release. label Mar 3, 2025
@RalfJung
Copy link
Member Author

RalfJung commented Mar 3, 2025

Closing in favor of #136831

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants