Add methods to TCP and UDP sockets to modify hop limit (refresh of #94678) #138744
+389
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ibraheemdev rustbot has assigned @ibraheemdev. Use |
rustbot
added
O-windows
|
r? libs-api because it's been a while since the original PR was approved. |
rustbot
added
the
T-libs-api
dtolnay
requested changes
Mar 30, 2025
rustbot
added
S-waiting-on-author
Open
4 tasks
This comment has been minimized.
This comment has been minimized.
Mallets
force-pushed
the
set_ipv6_sock_hop_limit
branch
from
7f790e2 to
9c1ee90
Compare
|
☔ The latest upstream changes (presumably #139724) made this pull request unmergeable. Please resolve the merge conflicts. |
Co-authored-by: David Tolnay <[email protected]>
|
Sorry—I missed that this was ready for review again. Please use |
dtolnay
force-pushed
the
set_ipv6_sock_hop_limit
branch
from
9c1ee90 to
25fb525
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
dtolnay
approved these changes
Apr 13, 2025
|
Thank you! @bors r+ |
bors
added
S-waiting-on-bors
ChrisDenton
added a commit
to ChrisDenton/rust
that referenced
this pull request
Apr 13, 2025
…=dtolnay Add methods to TCP and UDP sockets to modify hop limit (refresh of rust-lang#94678) rust-lang#94678 was closed because of time constraints of the original author (`@kckeiks).` This PR is a refresh of rust-lang#94678 where the original proposed changes are ported to the current status of the standard library. In addition, this PR: - implements the change suggested in rust-lang#94678 (comment) - defines `set_multicast_hop_limit_v6` and `multicast_hop_limit_v6 ` only for UDP sockets and not for TCP sockets as originally proposed Issue: rust-lang#139166
ChrisDenton
added a commit
to ChrisDenton/rust
that referenced
this pull request
Apr 13, 2025
…=dtolnay Add methods to TCP and UDP sockets to modify hop limit (refresh of rust-lang#94678) rust-lang#94678 was closed because of time constraints of the original author (``@kckeiks).`` This PR is a refresh of rust-lang#94678 where the original proposed changes are ported to the current status of the standard library. In addition, this PR: - implements the change suggested in rust-lang#94678 (comment) - defines `set_multicast_hop_limit_v6` and `multicast_hop_limit_v6 ` only for UDP sockets and not for TCP sockets as originally proposed Issue: rust-lang#139166
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 13, 2025
…enton Rollup of 12 pull requests Successful merges: - rust-lang#138744 (Add methods to TCP and UDP sockets to modify hop limit (refresh of rust-lang#94678)) - rust-lang#138962 (Expect an array when expected and acutal types are both arrays during cast) - rust-lang#139001 (add `naked_functions_rustic_abi` feature gate) - rust-lang#139379 (Use delayed bug for normalization errors in drop elaboration) - rust-lang#139582 (Various coercion cleanups) - rust-lang#139628 (Suggest remove redundant `$()?` around `vis`) - rust-lang#139644 (Micro-optimize `InstSimplify`'s `simplify_primitive_clone`) - rust-lang#139666 (cleanup `mir_borrowck`) - rust-lang#139674 (In `rustc_mir_transform`, iterate over index newtypes instead of ints) - rust-lang#139695 (compiletest: consistently use `camino::{Utf8Path,Utf8PathBuf}` throughout) - rust-lang#139722 (Move some things to rustc_type_ir) - rust-lang#139740 (Convert `tests/ui/lint/dead-code/self-assign.rs` to a known-bug test) r? `@ghost` `@rustbot` modify labels: rollup
|
failed in rollup #139755 (comment) @bors r- |
bors
added
S-waiting-on-author
|
I believe I have now fixed the unused_variable error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#94678 was closed because of time constraints of the original author (@kckeiks).
This PR is a refresh of #94678 where the original proposed changes are ported to the current status of the standard library.
In addition, this PR:
set_multicast_hop_limit_v6andmulticast_hop_limit_v6only for UDP sockets and not for TCP sockets as originally proposedIssue: #139166