Implement comparison operators for int and uint SIMD vectors #13899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let return_ty = Type::vector(&type_of(cx.ccx(), t), size as u64); | ||
| // LLVM outputs an `< size x i1 >`, so we need to perform a sign extension | ||
| // to get the correctly sized type. This will compile to a single instruction | ||
| // on once the IR is converted to assembly. |
There was a problem hiding this comment.
nit: remove "on". Also I would qualify this statement with "if the SIMD instruction is supported by the target architecture".
|
Looks good modulo one nit. |
bors
added a commit
that referenced
this pull request
May 3, 2014
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 9, 2025
Using `lifetime.ident.name` in suggestions will not output the raw modifier. For example, `'r#struct` will be rendered as `'struct` which would be incorrect. Fix rust-lang#13899 changelog: [`needless_arbitrary_self_type`]: use the raw lifetime name in suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc. @pcwalton