make abi_unsupported_vector_types a hard error #139309

RalfJung · 2025-04-03T09:05:14Z

Fixes #116558 by completing the transition; see that issue for context. The lint was introduced with Rust 1.84 and this has been shown in cargo's future breakage reports since Rust 1.85, released 6 weeks ago, and so far we got 0 complaints by users. There's not even a backlink on the tracking issue. We did a crater run when the lint was originally added and found no breakage. So I don't think we need another crater run now, but I can do one if the team prefers that.

#131800 is done, so for most current targets (in particular, all tier 1 and tier 2 targets) we have the information to implement this check (modulo the targets where we don't properly support SIMD vectors yet, see the sub-issues of #116558). If a new target gets added in the future, it will default to reject all SIMD vector types until proper information is added, which is the default we want.

This will need approval by for @rust-lang/lang. Cc @workingjubilee @veluca93

try-job: test-various
try-job: armhf-gnu

rustbot · 2025-04-03T09:05:19Z

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

RalfJung · 2025-04-03T11:32:18Z

tests/codegen/regparm-inreg.rs

@@ -3,7 +3,7 @@
 // x86 only.

 //@ add-core-stubs
-//@ compile-flags: --target i686-unknown-linux-gnu -Cno-prepopulate-passes -Copt-level=3
+//@ compile-flags: --target i686-unknown-linux-gnu -Cno-prepopulate-passes -Copt-level=3 -Ctarget-feature=+avx


@azhogin this test was using SIMD vector types without the appropriate target feature... I hope adding the target feature preserves the meaning of the test.

rustbot · 2025-04-03T13:45:58Z

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

compiler/rustc_codegen_cranelift/example/std_example.rs

rustbot · 2025-04-03T14:51:50Z

This PR modifies run-make tests.

cc @jieyouxu

RalfJung · 2025-04-03T17:05:34Z

tests/run-make/simd-ffi/rmake.rs

@@ -56,7 +56,7 @@ fn main() {
            .target(&target)
            .emit("llvm-ir,asm")
            .input("simd.rs")
-            .arg("-Ctarget-feature=-soft-float,+neon,+sse")
+            .arg("-Ctarget-feature=-soft-float,+neon,+sse2,+msa")
            .arg(&format!("-Cextra-filename=-{target}"))
            .run();


This test will become a complete nightmare to maintain when we start to properly enforce some basic consistency of target features.

ehuss · 2025-04-03T17:31:23Z

@RalfJung Do you think we can get this documented in the reference? Like maybe somewhere in the target_feature documentation or probably it makes more sense to be a part of the abi chapter with the abi chapter rework? Although I'm a little confused since Connor removed the SIMD section and I'm not sure why.

My uncertainty is emphasized because we currently don't really document SIMD, and I don't know how we plan to do that.

RalfJung · 2025-04-04T06:11:23Z

@RalfJung Do you think we can get this documented in the reference? Like maybe somewhere in the target_feature documentation or probably it makes more sense to be a part of the abi chapter with the abi chapter rework? Although I'm a little confused since Connor removed the SIMD section and I'm not sure why.

My uncertainty is emphasized because we currently don't really document SIMD, and I don't know how we plan to do that.

Seems like this should be part of rust-lang/reference#1545 so I'd rather not add a separate PR now, that would just be a huge conflict.

bors · 2025-04-09T06:46:15Z

☔ The latest upstream changes (presumably #139555) made this pull request unmergeable. Please resolve the merge conflicts.

RalfJung · 2025-04-22T06:49:03Z

@bors try

…s, r=<try> make abi_unsupported_vector_types a hard error Fixes rust-lang#116558 by completing the transition; see that issue for context. The lint was introduced with Rust 1.84 and this has been shown in cargo's future breakage reports since Rust 1.85, released 6 weeks ago, and so far we got 0 complaints by users. There's not even a backlink on the tracking issue. We did a [crater run](rust-lang#127731 (comment)) when the lint was originally added and found no breakage. So I don't think we need another crater run now, but I can do one if the team prefers that. rust-lang#131800 is done, so for most current targets (in particular, all tier 1 and tier 2 targets) we have the information to implement this check (modulo the targets where we don't properly support SIMD vectors yet, see the sub-issues of rust-lang#116558). If a new target gets added in the future, it will default to reject all SIMD vector types until proper information is added, which is the default we want. This will need approval by for `@rust-lang/lang.` Cc `@workingjubilee` `@veluca93` try-job: test-various

bors · 2025-04-22T06:50:14Z

⌛ Trying commit 8b62073 with merge 48459fb...

bors · 2025-04-22T08:13:29Z

☀️ Try build successful - checks-actions
Build commit: 48459fb (48459fb6792acf4cbf16ee54b58073c5beb06746)

RalfJung · 2025-04-22T08:48:05Z

@bors r=fee1-dead,traviscross

bors · 2025-04-22T08:48:09Z

📌 Commit 8b62073 has been approved by fee1-dead,traviscross

It is now in the queue for this repository.

…pes, r=fee1-dead,traviscross make abi_unsupported_vector_types a hard error Fixes rust-lang#116558 by completing the transition; see that issue for context. The lint was introduced with Rust 1.84 and this has been shown in cargo's future breakage reports since Rust 1.85, released 6 weeks ago, and so far we got 0 complaints by users. There's not even a backlink on the tracking issue. We did a [crater run](rust-lang#127731 (comment)) when the lint was originally added and found no breakage. So I don't think we need another crater run now, but I can do one if the team prefers that. rust-lang#131800 is done, so for most current targets (in particular, all tier 1 and tier 2 targets) we have the information to implement this check (modulo the targets where we don't properly support SIMD vectors yet, see the sub-issues of rust-lang#116558). If a new target gets added in the future, it will default to reject all SIMD vector types until proper information is added, which is the default we want. This will need approval by for `@rust-lang/lang.` Cc `@workingjubilee` `@veluca93` try-job: test-various

…enton Rollup of 8 pull requests Successful merges: - rust-lang#139309 (make abi_unsupported_vector_types a hard error) - rust-lang#139617 (Use posix_spawn on cygwin) - rust-lang#140072 (handle function alignment in miri) - rust-lang#140104 (Fix auto diff failing on inherent impl blocks) - rust-lang#140124 (Update books) - rust-lang#140144 (Handle another negated literal in `eat_token_lit`.) - rust-lang#140146 (Update `compiler_builtins` to 0.1.156) - rust-lang#140149 (test_nan: ensure the NAN contant is quiet) r? `@ghost` `@rustbot` modify labels: rollup

ChrisDenton · 2025-04-22T15:23:15Z

Failed in rollup: #140161 (comment)

@bors r-

RalfJung · 2025-04-22T15:29:34Z

@bors rollup=never

RalfJung · 2025-04-22T15:32:44Z

@bors try

…s, r=<try> make abi_unsupported_vector_types a hard error Fixes rust-lang#116558 by completing the transition; see that issue for context. The lint was introduced with Rust 1.84 and this has been shown in cargo's future breakage reports since Rust 1.85, released 6 weeks ago, and so far we got 0 complaints by users. There's not even a backlink on the tracking issue. We did a [crater run](rust-lang#127731 (comment)) when the lint was originally added and found no breakage. So I don't think we need another crater run now, but I can do one if the team prefers that. rust-lang#131800 is done, so for most current targets (in particular, all tier 1 and tier 2 targets) we have the information to implement this check (modulo the targets where we don't properly support SIMD vectors yet, see the sub-issues of rust-lang#116558). If a new target gets added in the future, it will default to reject all SIMD vector types until proper information is added, which is the default we want. This will need approval by for `@rust-lang/lang.` Cc `@workingjubilee` `@veluca93` try-job: test-various try-job: armhf-gnu

bors · 2025-04-22T15:33:55Z

⌛ Trying commit 5875605 with merge 40d505b1cc023e2148c0204d4e9af6c4a34dd1d1...

bors · 2025-04-22T16:36:47Z

💔 Test failed - checks-actions

RalfJung · 2025-04-23T06:41:35Z

@bors try

…s, r=<try> make abi_unsupported_vector_types a hard error Fixes rust-lang#116558 by completing the transition; see that issue for context. The lint was introduced with Rust 1.84 and this has been shown in cargo's future breakage reports since Rust 1.85, released 6 weeks ago, and so far we got 0 complaints by users. There's not even a backlink on the tracking issue. We did a [crater run](rust-lang#127731 (comment)) when the lint was originally added and found no breakage. So I don't think we need another crater run now, but I can do one if the team prefers that. rust-lang#131800 is done, so for most current targets (in particular, all tier 1 and tier 2 targets) we have the information to implement this check (modulo the targets where we don't properly support SIMD vectors yet, see the sub-issues of rust-lang#116558). If a new target gets added in the future, it will default to reject all SIMD vector types until proper information is added, which is the default we want. This will need approval by for `@rust-lang/lang.` Cc `@workingjubilee` `@veluca93` try-job: test-various try-job: armhf-gnu

bors · 2025-04-23T06:42:46Z

⌛ Trying commit 64d0bb2 with merge 38a9dffa5728c708611806992f4b44be159706a8...

bors · 2025-04-23T08:05:55Z

☀️ Try build successful - checks-actions
Build commit: 38a9dff (38a9dffa5728c708611806992f4b44be159706a8)

rustbot assigned fee1-dead Apr 3, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 3, 2025

RalfJung added I-lang-nominated Nominated for discussion during a lang team meeting. I-lang-easy-decision Issue: The decision needed by the team is conjectured to be easy; this does not imply nomination labels Apr 3, 2025

This comment has been minimized.

Sign in to view

RalfJung force-pushed the abi_unsupported_vector_types branch from f4e41c2 to 607bd91 Compare April 3, 2025 10:30

This comment has been minimized.

Sign in to view

RalfJung force-pushed the abi_unsupported_vector_types branch from 607bd91 to 39f82c8 Compare April 3, 2025 11:31

RalfJung commented Apr 3, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

RalfJung force-pushed the abi_unsupported_vector_types branch from 39f82c8 to d817e10 Compare April 3, 2025 12:41

This comment has been minimized.

Sign in to view

RalfJung force-pushed the abi_unsupported_vector_types branch from d817e10 to 00743be Compare April 3, 2025 13:45

RalfJung commented Apr 3, 2025

View reviewed changes

compiler/rustc_codegen_cranelift/example/std_example.rs Show resolved Hide resolved

This comment has been minimized.

Sign in to view

RalfJung force-pushed the abi_unsupported_vector_types branch from 00743be to 764fe74 Compare April 3, 2025 14:51

rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Apr 3, 2025

This comment has been minimized.

Sign in to view

RalfJung force-pushed the abi_unsupported_vector_types branch from 764fe74 to f6eb25c Compare April 3, 2025 17:04

RalfJung commented Apr 3, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

RalfJung force-pushed the abi_unsupported_vector_types branch from f6eb25c to 5bbf200 Compare April 4, 2025 06:01

ehuss mentioned this pull request Apr 4, 2025

Spec abi chapter rust-lang/reference#1545

Open

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 20, 2025

jieyouxu removed the S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. label Apr 21, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 22, 2025

ChrisDenton mentioned this pull request Apr 22, 2025

Rollup of 8 pull requests #140161

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 22, 2025

RalfJung force-pushed the abi_unsupported_vector_types branch from 8b62073 to 5875605 Compare April 22, 2025 15:32

This comment has been minimized.

Sign in to view

wasm, arm need simd to be explicitly enabled

64d0bb2

RalfJung force-pushed the abi_unsupported_vector_types branch from 5875605 to 64d0bb2 Compare April 23, 2025 06:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make abi_unsupported_vector_types a hard error #139309

make abi_unsupported_vector_types a hard error #139309

RalfJung commented Apr 3, 2025 •

edited

Loading

rustbot commented Apr 3, 2025

This comment has been minimized.

This comment has been minimized.

RalfJung Apr 3, 2025

workingjubilee Apr 3, 2025

This comment has been minimized.

This comment has been minimized.

rustbot commented Apr 3, 2025

This comment has been minimized.

rustbot commented Apr 3, 2025

This comment has been minimized.

RalfJung Apr 3, 2025

ehuss commented Apr 3, 2025

This comment has been minimized.

RalfJung commented Apr 4, 2025

bors commented Apr 9, 2025

RalfJung commented Apr 22, 2025

bors commented Apr 22, 2025

bors commented Apr 22, 2025

RalfJung commented Apr 22, 2025 via email

bors commented Apr 22, 2025

ChrisDenton commented Apr 22, 2025

RalfJung commented Apr 22, 2025

RalfJung commented Apr 22, 2025

bors commented Apr 22, 2025

This comment has been minimized.

bors commented Apr 22, 2025

RalfJung commented Apr 23, 2025

bors commented Apr 23, 2025

bors commented Apr 23, 2025

make abi_unsupported_vector_types a hard error #139309

Are you sure you want to change the base?

make abi_unsupported_vector_types a hard error #139309

Conversation

RalfJung commented Apr 3, 2025 • edited Loading

rustbot commented Apr 3, 2025

This comment has been minimized.

This comment has been minimized.

RalfJung Apr 3, 2025

Choose a reason for hiding this comment

workingjubilee Apr 3, 2025

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

rustbot commented Apr 3, 2025

This comment has been minimized.

rustbot commented Apr 3, 2025

This comment has been minimized.

RalfJung Apr 3, 2025

Choose a reason for hiding this comment

ehuss commented Apr 3, 2025

This comment has been minimized.

RalfJung commented Apr 4, 2025

bors commented Apr 9, 2025

RalfJung commented Apr 22, 2025

bors commented Apr 22, 2025

bors commented Apr 22, 2025

RalfJung commented Apr 22, 2025 via email

bors commented Apr 22, 2025

ChrisDenton commented Apr 22, 2025

RalfJung commented Apr 22, 2025

RalfJung commented Apr 22, 2025

bors commented Apr 22, 2025

This comment has been minimized.

bors commented Apr 22, 2025

RalfJung commented Apr 23, 2025

bors commented Apr 23, 2025

bors commented Apr 23, 2025

RalfJung commented Apr 3, 2025 •

edited

Loading