Skip to content

Update cargo #139439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2025
Merged

Update cargo #139439

merged 1 commit into from
Apr 6, 2025

Conversation

weihanglo
Copy link
Member

17 commits in a6c604d1b8a2f2a8ff1f3ba6092f9fda42f4b7e9..0e93c5bf6a1d5ee7bc2af63d1afb16cd28793601
2025-03-26 18:11:00 +0000 to 2025-04-05 00:00:24 +0000

r? ghost

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 6, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot
Copy link
Collaborator

rustbot commented Apr 6, 2025

⚠️ Warning ⚠️

  • These commits modify submodules.

@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Apr 6, 2025

📌 Commit 3034e57 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2025
@bors
Copy link
Collaborator

bors commented Apr 6, 2025

⌛ Testing commit 3034e57 with merge 175dcc7...

@bors
Copy link
Collaborator

bors commented Apr 6, 2025

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 175dcc7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 6, 2025
@bors bors merged commit 175dcc7 into rust-lang:master Apr 6, 2025
7 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 6, 2025
Copy link

github-actions bot commented Apr 6, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f5c5102 (parent) -> 175dcc7 (this PR)

Test differences

Show 33025 test diffs

Stage 1

  • btree::set::clone_10k_and_into_iter: pass -> [missing] (J0)
  • fs::tests::sync_doesnt_kill_anything: pass -> [missing] (J0)
  • fs::tests::write_then_read: pass -> [missing] (J0)
  • net::addr_parser::bench_parse_ipv4: pass -> [missing] (J0)
  • num::flt2dec::strategy::grisu::bench_big_exact_3: pass -> [missing] (J0)
  • slice::sort_large_ascending: pass -> [missing] (J0)
  • sort::tests::stable::correct_u64_descending: pass -> [missing] (J0)
  • sort::tests::stable::deterministic_cell_i32_random_d2: pass -> [missing] (J0)
  • sort::tests::stable::deterministic_i32_random_s95: pass -> [missing] (J0)
  • sort::tests::unstable::correct_string_random: pass -> [missing] (J0)
  • stats::tests::test_min_max_nan: pass -> [missing] (J0)
  • array::array_from_fn: pass -> [missing] (J1)
  • collections::btree::set::tests::test_iter_min_max: pass -> [missing] (J1)
  • collections::hash::set::tests::test_move_iter: pass -> [missing] (J1)
  • f128::test_infinity: pass -> [missing] (J1)
  • iter::adapters::flatten::test_flatten_last: pass -> [missing] (J1)
  • log_knows_the_names_of_variants_in_std: pass -> [missing] (J1)
  • misc_tests::any_move: pass -> [missing] (J1)
  • mpmc::oneshot_single_thread_try_send_open: pass -> [missing] (J1)
  • net::ip_addr::test_from_str_ipv6: pass -> [missing] (J1)
  • num::dec2flt::lonely_sign: pass -> [missing] (J1)
  • num::i64::test_signed_checked_div: pass -> [missing] (J1)
  • option::test_option_as_deref: pass -> [missing] (J1)
  • option::test_unwrap_drop: pass -> [missing] (J1)
  • rwlock::test_rwlock_unsized: pass -> [missing] (J1)
  • slice::memchr::matches_end: pass -> [missing] (J1)
  • slice::test_clear: pass -> [missing] (J1)
  • slice::test_get_disjoint_mut_range_overlapping: pass -> [missing] (J1)
  • sort::tests::unstable::panic_retain_orig_set_i32_random_z1: pass -> [missing] (J1)
  • str::utf8_chars: pass -> [missing] (J1)
  • string::test_replace_range_end_overflow: pass -> [missing] (J1)
  • thin_box::align1big: pass -> [missing] (J1)
  • thread::tests::test_thread_id_not_equal: pass -> [missing] (J1)
  • vec::test_clone: pass -> [missing] (J1)
  • vec::test_retain_drop_panic: pass -> [missing] (J1)
  • vec_deque::test_append_zst_capacity_overflow: pass -> [missing] (J1)
  • vec_deque::test_get_mut: pass -> [missing] (J1)
  • sort::tests::stable::correct_i32_random_z2: ignore -> [missing] (J2)
  • sort::tests::stable::correct_u128_random_s95: ignore -> [missing] (J2)
  • sort::tests::unstable::stability_i32_random_d20: ignore -> [missing] (J2)
  • sort::tests::unstable::stability_i32_saw_mixed: ignore -> [missing] (J2)
  • clean::types::tests::is_same_generic: pass -> [missing] (J3)
  • errors::verify_codegen_ssa_invalid_monomorphization_cast_wide_pointer_121: pass -> [missing] (J3)
  • errors::verify_codegen_ssa_invalid_monomorphization_third_argument_length_104: pass -> [missing] (J3)
  • errors::verify_const_eval_long_running_24: pass -> [missing] (J3)
  • errors::verify_const_eval_non_const_fmt_macro_call_17: pass -> [missing] (J3)
  • errors::verify_hir_typeck_union_pat_multiple_fields_15: pass -> [missing] (J3)
  • errors::verify_parse_enum_struct_mutually_exclusive_79: pass -> [missing] (J3)
  • errors::verify_parse_macro_name_remove_bang_144: pass -> [missing] (J3)
  • errors::verify_passes_layout_align_116: pass -> [missing] (J3)
  • errors::verify_passes_rustc_allow_const_fn_unstable_82: pass -> [missing] (J3)
  • errors::verify_resolve_macro_expanded_extern_crate_cannot_shadow_extern_arguments_45: pass -> [missing] (J3)
  • lints::verify_lint_builtin_no_mangle_method_17: pass -> [missing] (J3)
  • lints::verify_lint_enum_intrinsics_mem_discriminant_40: pass -> [missing] (J3)

Stage 2

  • fs::tests::binary_file: [missing] -> pass (J0)
  • num::int_sqrt::i8::isqrt_extended: [missing] -> pass (J0)
  • sort::tests::stable::violate_ord_retain_orig_set_i32_saw_mixed: [missing] -> pass (J0)
  • sort::tests::unstable::correct_i32_random_d4: [missing] -> pass (J0)
  • sort::tests::unstable::deterministic_i32_ascending: [missing] -> pass (J0)
  • sort::tests::unstable::panic_retain_orig_set_i32_saw_mixed: [missing] -> pass (J0)
  • sort::tests::unstable::panic_retain_orig_set_string_saw_mixed: [missing] -> pass (J0)
  • vec::bench_clone_1000: [missing] -> pass (J0)
  • vec::bench_extend_from_slice_0000_1000: [missing] -> pass (J0)
  • vec_deque::bench_extend_chained_bytes: [missing] -> pass (J0)
  • collections::binary_heap::test_exact_size_iterator: [missing] -> pass (J1)
  • collections::vec_deque::tests::bench_pop_back_100: [missing] -> pass (J1)
  • collections::vec_deque::tests::issue_108453: [missing] -> pass (J1)
  • f16::test_neg_zero: [missing] -> pass (J1)
  • f32::test_trunc: [missing] -> pass (J1)
  • io::buffered::tests::bench_buffered_writer: [missing] -> pass (J1)
  • io::tests::test_write_all_vectored: [missing] -> pass (J1)
  • iter::sources::test_repeat_n_drop: [missing] -> pass (J1)
  • mem::uninit_write_iter_partial: [missing] -> pass (J1)
  • misc_tests::f64_slice: [missing] -> pass (J1)
  • mpmc::send_from_outside_runtime: [missing] -> pass (J1)
  • net::ip_addr::is_v6: [missing] -> pass (J1)
  • num::f32::midpoint: [missing] -> pass (J1)
  • num::i32::test_swap_bytes: [missing] -> pass (J1)
  • option::test_unwrap_or_else: [missing] -> pass (J1)
  • slice::split_off_mut_in_bounds_range_from: [missing] -> pass (J1)
  • slice::test_slice_partition_dedup_one: [missing] -> pass (J1)
  • str::slice_index::boundary::rangefrom::index_mut_fail: [missing] -> pass (J1)
  • str::slice_index::boundary::rangeinclusive_2::index_fail: [missing] -> pass (J1)
  • str::slice_index::boundary::rangeto::index_fail: [missing] -> pass (J1)
  • sort::tests::stable::violate_ord_retain_orig_set_string_ascending: [missing] -> ignore (J2)
  • sort::tests::unstable::correct_i32_all_equal: [missing] -> ignore (J2)
  • sort::tests::unstable::panic_observable_is_less_descending: [missing] -> ignore (J2)
  • bit_set::tests::bitset_clone_from: [missing] -> pass (J3)
  • doctest::tests::make_test_dont_insert_main: [missing] -> pass (J3)
  • errors::verify_ast_lowering_abi_specified_multiple_times_11: [missing] -> pass (J3)
  • errors::verify_codegen_ssa_invalid_monomorphization_basic_float_type_90: [missing] -> pass (J3)
  • errors::verify_const_eval_long_running_25: [missing] -> pass (J3)
  • errors::verify_metadata_multiple_kinds_in_link_8: [missing] -> pass (J3)
  • errors::verify_parse_expected_mut_or_const_in_raw_pointer_type_122: [missing] -> pass (J3)
  • errors::verify_parse_incorrect_visibility_restriction_38: [missing] -> pass (J3)
  • errors::verify_parse_use_eq_instead_30: [missing] -> pass (J3)
  • html::length_limit::tests::empty: [missing] -> pass (J3)
  • lints::verify_lint_only_cast_u8_to_char_83: [missing] -> pass (J3)
  • spec::tests::mips64el_unknown_linux_gnuabi64: [missing] -> pass (J3)
  • sys::thread_local::key::tests::smoke: [missing] -> pass (J4)

(and 16429 additional test diffs)

Additionally, 16496 doctest diffs were found. These are ignored, as they are noisy.

Job group index

  • J0: aarch64-apple, test-various, x86_64-apple-1
  • J1: aarch64-apple, test-various, x86_64-apple-1, x86_64-gnu-aux
  • J2: x86_64-gnu-aux
  • J3: aarch64-apple, x86_64-apple-1
  • J4: test-various, x86_64-gnu-aux

Job duration changes

  1. aarch64-gnu-debug: 4102.6s -> 6436.2s (56.9%)
  2. dist-s390x-linux: 5198.0s -> 5826.6s (12.1%)
  3. aarch64-gnu: 6362.8s -> 6774.7s (6.5%)
  4. dist-various-1: 4381.2s -> 4634.1s (5.8%)
  5. x86_64-gnu-stable: 6603.8s -> 6910.7s (4.6%)
  6. dist-x86_64-illumos: 5645.6s -> 5895.7s (4.4%)
  7. x86_64-gnu-llvm-19-2: 5952.8s -> 6193.9s (4.0%)
  8. dist-x86_64-msvc-alt: 7335.8s -> 7616.2s (3.8%)
  9. dist-arm-linux: 5461.3s -> 5667.5s (3.8%)
  10. x86_64-gnu: 6382.4s -> 6621.8s (3.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (175dcc7): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.3% [2.3%, 2.3%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-5.9% [-5.9%, -5.9%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.8% [-5.9%, 2.3%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (secondary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.0% [0.0%, 0.0%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Bootstrap: 776.062s -> 776.533s (0.06%)
Artifact size: 365.87 MiB -> 365.95 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants