-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Use thread local dep graph encoding #139758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit 8167fdb with merge 5545f9c456a47860eda2f034f2d7636b31cff81c... |
Use thread local dep graph encoding This adds thread local encoding of dep graph nodes. Each thread has a `MemEncoder` that gets flushed to the global `FileEncoder` when it exceeds 64 kB. Each thread also has a local cache of dep indices. This means there can now be empty gaps in `SerializedDepGraph`. Indices are marked green and also allocated by the new atomic operation `DepNodeColorMap::try_mark_green` as the encoder lock is removed. This is based on rust-lang#139636 and rust-lang#139756.
Local results, 1 thread, including #139756, excluding #139636:
Local results, 7 threads, including #139756, excluding #139636:
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (5545f9c): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 1.8%, secondary 0.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 779.607s -> 782.154s (0.33%) |
r? compiler |
8167fdb
to
7d236d0
Compare
This adds thread local encoding of dep graph nodes. Each thread has a
MemEncoder
that gets flushed to the globalFileEncoder
when it exceeds 64 kB. Each thread also has a local cache of dep indices. This means there can now be empty gaps inSerializedDepGraph
.Indices are marked green and also allocated by the new atomic operation
DepNodeColorMap::try_mark_green
as the encoder lock is removed.This is based on #139636 and #139756.