Avoid redundant WTF-8 checks in PathBuf
#140159
Open
+57
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Communicate the safety invariants of these methods with `unsafe fn` rather than privacy.
Eliminate checks for WTF-8 boundaries in `PathBuf::set_extension` and `add_extension`, where joining WTF-8 surrogate halves is impossible. Don't convert the `str` to `OsStr`, because `OsString::push` specializes to skip the joining when given strings.
|
rustbot has assigned @workingjubilee. Use |
rustbot
added
S-waiting-on-review
thaliaarchi
force-pushed
the
pathbuf-extension
branch
from
72b18d0 to
bd2e262
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate checks for WTF-8 boundaries in
PathBuf::set_extensionandadd_extension, where joining WTF-8 surrogate halves is impossible. Don't convert thestrtoOsStr, becauseOsString::pushspecializes to skip the joining when given strings.To assist in this, mark the internal methods
OsString::truncateandextend_from_sliceasunsafeto communicate their safety invariants better than with module privacy.Similar to #137777.
cc @joboet @ChrisDenton