Skip to content

Make rustdoc-tempdir-removal run-make tests work on other platforms than linux #140800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

GuillaumeGomez
Copy link
Member

Follow-up of #140706.

r? @jieyouxu

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 8, 2025

This PR modifies run-make tests.

cc @jieyouxu

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, then r=me, thanks!

@GuillaumeGomez GuillaumeGomez force-pushed the rustdoc-tempdir-removal branch from 489c506 to 41ff588 Compare May 8, 2025 13:24
@jieyouxu
Copy link
Member

jieyouxu commented May 8, 2025

Cool!
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 8, 2025

📌 Commit 41ff588 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 8, 2025
…oval, r=jieyouxu

Make `rustdoc-tempdir-removal` run-make tests work on other platforms than linux

Follow-up of rust-lang#140706.

r? ``@jieyouxu``
bors added a commit to rust-lang-ci/rust that referenced this pull request May 8, 2025
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#140095 (Eliminate `word_and_empty` methods.)
 - rust-lang#140341 (Clarify black_box warning a bit)
 - rust-lang#140684 (Only include `dyn Trait<Assoc = ...>` associated type bounds for `Self: Sized` associated types if they are provided)
 - rust-lang#140707 (Structurally normalize in range pattern checking in HIR typeck)
 - rust-lang#140716 (Improve `-Zremap-path-scope` tests with dependency)
 - rust-lang#140800 (Make `rustdoc-tempdir-removal` run-make tests work on other platforms than linux)
 - rust-lang#140802 (Add release notes for 1.87.0)
 - rust-lang#140811 (Enable triagebot note functionality for rust-lang/rust)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8d7a4c2 into rust-lang:master May 9, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone May 9, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 9, 2025
Rollup merge of rust-lang#140800 - GuillaumeGomez:rustdoc-tempdir-removal, r=jieyouxu

Make `rustdoc-tempdir-removal` run-make tests work on other platforms than linux

Follow-up of rust-lang#140706.

r? `@jieyouxu`
@GuillaumeGomez GuillaumeGomez deleted the rustdoc-tempdir-removal branch May 9, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants