Skip to content

replace cc_detect::cc2ar with cc::try_get_archiver #140994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

onur-ozkan
Copy link
Member

@onur-ozkan onur-ozkan commented May 14, 2025

Awaiting new release of cc version with rust-lang/cc-rs#1456 to bump the version.

Blocked by rust-lang/cc-rs#1456.

Kind a self-explanatory.

try-job: arm-android

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label May 14, 2025
@onur-ozkan onur-ozkan marked this pull request as ready for review May 16, 2025 18:09
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 16, 2025
@onur-ozkan
Copy link
Member Author

r? bootstrap

Copy link
Member

@albertlarsan68 albertlarsan68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@albertlarsan68
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented May 17, 2025

📌 Commit 5027ee2 has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2025
fmease added a commit to fmease/rust that referenced this pull request May 18, 2025
…larsan68

replace `cc_detect::cc2ar` with `cc::try_get_archiver`

~~Awaiting new release of [cc](https://crates.io/crates/cc) version with rust-lang/cc-rs#1456 to bump the version.~~

~~Blocked by rust-lang/cc-rs#1456

Kind a self-explanatory.
bors added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2025
Rollup of 6 pull requests

Successful merges:

 - rust-lang#127013 (Add `f16` formatting and parsing)
 - rust-lang#140154 (Cygwin support in rustc)
 - rust-lang#140628 (std: stop using TLS in signal handler)
 - rust-lang#140966 (Remove #![feature(let_chains)] from library and src/librustdoc)
 - rust-lang#140994 (replace `cc_detect::cc2ar` with `cc::try_get_archiver`)
 - rust-lang#141127 (bump windows crate for compiler,bootstrap and tools)

r? `@ghost`
`@rustbot` modify labels: rollup
@fmease
Copy link
Member

fmease commented May 18, 2025

Likely caused the failure in this rollup: #141208 (comment) #141208 (comment) (arm-android)

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 18, 2025
@fmease
Copy link
Member

fmease commented May 18, 2025

(arm-android) @bors try

@bors
Copy link
Collaborator

bors commented May 18, 2025

⌛ Trying commit 5027ee2 with merge 481b6aa48959e6791a4da16597daec86f03389fc...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2025
replace `cc_detect::cc2ar` with `cc::try_get_archiver`

~~Awaiting new release of [cc](https://crates.io/crates/cc) version with rust-lang/cc-rs#1456 to bump the version.~~

~~Blocked by rust-lang/cc-rs#1456

Kind a self-explanatory.

try-job: arm-android
@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented May 18, 2025

💔 Test failed - checks-actions

@onur-ozkan
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented May 19, 2025

⌛ Trying commit 88eedfa with merge d154c46...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 19, 2025
replace `cc_detect::cc2ar` with `cc::try_get_archiver`

~~Awaiting new release of [cc](https://crates.io/crates/cc) version with rust-lang/cc-rs#1456 to bump the version.~~

~~Blocked by rust-lang/cc-rs#1456

Kind a self-explanatory.

try-job: arm-android
@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented May 19, 2025

💔 Test failed - checks-actions

@onur-ozkan
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented May 19, 2025

⌛ Trying commit 53ca86c with merge 05c2305584f42c660ae1f03290e7cfaede74de72...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 19, 2025
replace `cc_detect::cc2ar` with `cc::try_get_archiver`

~~Awaiting new release of [cc](https://crates.io/crates/cc) version with rust-lang/cc-rs#1456 to bump the version.~~

~~Blocked by rust-lang/cc-rs#1456

Kind a self-explanatory.

try-job: arm-android
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented May 19, 2025

💔 Test failed - checks-actions

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 19, 2025
@onur-ozkan
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request May 19, 2025
replace `cc_detect::cc2ar` with `cc::try_get_archiver`

~~Awaiting new release of [cc](https://crates.io/crates/cc) version with rust-lang/cc-rs#1456 to bump the version.~~

~~Blocked by rust-lang/cc-rs#1456

Kind a self-explanatory.

try-job: arm-android
@bors
Copy link
Collaborator

bors commented May 19, 2025

⌛ Trying commit d466c53 with merge a131ad86a0821b065114c0b69f58b2090feadf34...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented May 19, 2025

☀️ Try build successful - checks-actions
Build commit: a131ad8 (a131ad86a0821b065114c0b69f58b2090feadf34)

Signed-off-by: onur-ozkan <[email protected]>
@onur-ozkan
Copy link
Member Author

Fixed the CI issue.

@bors r=albertlarsan68

@bors
Copy link
Collaborator

bors commented May 19, 2025

📌 Commit 3d50f0e has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 19, 2025
@bors
Copy link
Collaborator

bors commented May 19, 2025

⌛ Testing commit 3d50f0e with merge edfe9cb...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 19, 2025
…rsan68

replace `cc_detect::cc2ar` with `cc::try_get_archiver`

~~Awaiting new release of [cc](https://crates.io/crates/cc) version with rust-lang/cc-rs#1456 to bump the version.~~

~~Blocked by rust-lang/cc-rs#1456

Kind a self-explanatory.

try-job: arm-android
@rust-log-analyzer
Copy link
Collaborator

The job dist-android failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented May 19, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants