gather_locals: only visit guard pattern guards when checking the guard
#141275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking a pattern with guards in it, `GatherLocalsVisitor` will visit both the pattern (when type-checking the let, arm, or param containing it) and the guard expression (when checking the guard itself). This keeps it from visiting the guard when visiting the pattern, since otherwise it would gather locals from the guard twice, which would lead to a delayed bug: "evaluated expression more than once".
|
r? @nnethercote rustbot has assigned @nnethercote. Use |
rustbot
added
S-waiting-on-review
nnethercote
reviewed
May 20, 2025
| @@ -218,7 +218,12 @@ impl<'a, 'tcx> Visitor<'tcx> for GatherLocalsVisitor<'a, 'tcx> { | |||
| ); | |||
| } | |||
| let old_outermost_fn_param_pat = self.outermost_fn_param_pat.take(); | |||
| intravisit::walk_pat(self, p); | |||
| if let PatKind::Guard(subpat, _) = p.kind { | |||
| // We'll visit the guard when checking it. Don't gather its locals twice. | |||
There was a problem hiding this comment.
Sorry, I don't understand this. When is the guard expression checked, if not here?
There was a problem hiding this comment.
It's checked in check_pat_inner; see the check_expr_has_type_or_error call there.
compiler-errors
approved these changes
May 20, 2025
There was a problem hiding this comment.
This makes sense. Since I introduced the regression, I'm happy to approve it. It's kinda a shame we have to special case guards here, but it makes sense, since this is the only case where we have a nested expr within a pattern.
We could alternatively do something like override visit_expr to be a noop, but whatever, this current approach keeps the behavior more localized.
| @@ -218,7 +218,12 @@ impl<'a, 'tcx> Visitor<'tcx> for GatherLocalsVisitor<'a, 'tcx> { | |||
| ); | |||
| } | |||
| let old_outermost_fn_param_pat = self.outermost_fn_param_pat.take(); | |||
| intravisit::walk_pat(self, p); | |||
| if let PatKind::Guard(subpat, _) = p.kind { | |||
| // We'll visit the guard when checking it. Don't gather its locals twice. | |||
There was a problem hiding this comment.
It's checked in check_pat_inner; see the check_expr_has_type_or_error call there.
|
r? compiler-errors @bors r+ rollup |
bors
added
S-waiting-on-bors
8 tasks
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 20, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#139419 (Error on recursive opaque ty in HIR typeck) - rust-lang#141236 (Resolved issue with mismatched types triggering ICE in certain scenarios) - rust-lang#141253 (Warning added when dependency crate has async drop types, and the feature is disabled) - rust-lang#141269 (rustc-dev-guide subtree update) - rust-lang#141275 (`gather_locals`: only visit guard pattern guards when checking the guard) - rust-lang#141279 (`lower_to_hir` cleanups) - rust-lang#141285 (Add tick to `RePlaceholder` debug output) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 20, 2025
Rollup merge of rust-lang#141275 - dianne:gather-guard-pat-locals-once, r=compiler-errors `gather_locals`: only visit guard pattern guards when checking the guard When checking a pattern with guards in it, `GatherLocalsVisitor` will visit both the pattern (when type-checking the let, arm, or param containing it) and local declarations in the guard expression (when checking the guard itself). This keeps it from visiting the guard when visiting the pattern, since otherwise it would gather locals from the guard twice, which would lead to a delayed bug: "evaluated expression more than once". Tracking issue for guard patterns: rust-lang#129967
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking a pattern with guards in it,
GatherLocalsVisitorwill visit both the pattern (when type-checking the let, arm, or param containing it) and local declarations in the guard expression (when checking the guard itself). This keeps it from visiting the guard when visiting the pattern, since otherwise it would gather locals from the guard twice, which would lead to a delayed bug: "evaluated expression more than once".Tracking issue for guard patterns: #129967