Skip to content

Add missing dyn keywords to tests that do not test for them #141889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jun 2, 2025

This ensures that these tests can be run on editions other than 2015

This ensures that these tests can be run on editions other than 2015
@rustbot
Copy link
Collaborator

rustbot commented Jun 2, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 2, 2025
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 2, 2025

📌 Commit aba70e8 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 2, 2025
…rochenkov

Add missing `dyn` keywords to tests that do not test for them

This ensures that these tests can be run on editions other than 2015
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 2, 2025
…rochenkov

Add missing `dyn` keywords to tests that do not test for them

This ensures that these tests can be run on editions other than 2015
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 3, 2025
…rochenkov

Add missing `dyn` keywords to tests that do not test for them

This ensures that these tests can be run on editions other than 2015
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 3, 2025
…rochenkov

Add missing `dyn` keywords to tests that do not test for them

This ensures that these tests can be run on editions other than 2015
bors added a commit that referenced this pull request Jun 3, 2025
Rollup of 8 pull requests

Successful merges:

 - #140715 (Clarify &mut-methods' docs on sync::OnceLock)
 - #141677 (Async drop - type instead of async drop fn, fixes #140484)
 - #141741 (Overhaul `UsePath`)
 - #141873 (Fixed a typo in `ManuallyDrop`'s doc)
 - #141876 (Don't declare variables in `ExprKind::Let` in invalid positions)
 - #141886 (Add missing 2015 edition directives)
 - #141889 (Add missing `dyn` keywords to tests that do not test for them)
 - #141891 (Fix borrowck mentioning a name from an external macro we (deliberately) don't save)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d7fcb09 into rust-lang:master Jun 3, 2025
9 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 3, 2025
rust-timer added a commit that referenced this pull request Jun 3, 2025
Rollup merge of #141889 - ferrocene:lw/missing-dyn-kw, r=petrochenkov

Add missing `dyn` keywords to tests that do not test for them

This ensures that these tests can be run on editions other than 2015
@tshepang tshepang deleted the lw/missing-dyn-kw branch June 3, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants